1312880 - Use initialProcessData for RemoteAddonsChild rather than a sync message

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

The sync message happens here:
http://searchfox.org/mozilla-central/rev/e3e8571c5378ac92663d4f583ccc4ad0a3019716/toolkit/components/addoncompat/RemoteAddonsChild.jsm#52

We should be able to replace that using initialProcessData.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1312880 - Remove sync message when starting up RemoteAddonsChild.

Review commit: https://reviewboard.mozilla.org/r/89314/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89314/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8805544 [details]
Bug 1312880 - Remove sync message when starting up RemoteAddonsChild.

https://reviewboard.mozilla.org/r/89314/#review88650

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b1ef926af1c
Remove sync message when starting up RemoteAddonsChild. r=billm

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8b1ef926af1c

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8805544 [details]
Bug 1312880 - Remove sync message when starting up RemoteAddonsChild.

Approval Request Comment
[Feature/regressing bug #]:

Add-on shims and e10s.

[User impact if declined]:

Slightly worse performance on tab switch / content process performance when a new tab or window opens.

[Describe test coverage new/current, TreeHerder]:

The add-on shim tests still work, and this has been on Nightly for a few days. The dashboard that chutten set up at https://chutten.github.io/bug1310250/ shows the win from this fix appearing in the Oct 30th Nightly.

[Risks and why]: 

Very low risk.

[String/UUID change made/needed]:

None.

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Brad, Jim, at this point in RC 50 we are in Code Freeze mode and only taking fixes for release blocking issues. Is this something that would lead to a dot release once 50 goes live? If not, I'd prefer to take it in 50.1.0 (if deemed necessary) or let it ride the 51 release train. Do you anticipate this fix to disrupt the 50 crash rates? It has taken us a few weeks to get to a ship-worthy state from stability pov and I am wondering if this fix is safe from that aspect.

Comment 7

[Brad Lassey [:blassey] (use needinfo?)]

IMO we should take this for 51 but not 50. This should change timings and there are just too many timing interactions to be certain that this is risk free.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Thanks Brad! We'll let this one ride the 51 release train.

Comment 9

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8805544 [details]
Bug 1312880 - Remove sync message when starting up RemoteAddonsChild.

Let's uplift to Aurora51. This is a no-go for 50.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/186178aa5484