1312888 - Incorrect debug output for V2 lists

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P3)

Description

[François Marier [:francois]]

It looks like we have debugging output which displays the state of V2 lists too (not just V4):

test-unwanted-simple;a:1
mozplugin-block-digest256;a:1471849627
test-block-simple;a:1
test-phish-simple;a:1
goog-malware-proto;Cg0IARAGGAEiAzAwMTABEMehARoCGAUgLHMd:JmJe54oDbg7m5rgiGPMabKyX15GJmVoqhr99OVz7ksU=
googpub-phish-proto;Cg0IAhAGGAEiAzAwMTABEIieARoCGAXkh2Jf:H1qGz+g9T/2uYQgV3jplvNiwHkQu2Bl2My5lGZO1UCs=
goog-unwanted-proto;Cg0IAxAGGAEiAzAwMTABEJuJARoCGAW5gY5F:IOC4YQMEKuTI5Hyr8IVtnChhHr4Nf1WBEcAghp1Wsh8=

listmanager: 18:27:08 GMT-0400 (EDT): test-trackwhite-simple ==> a
listmanager: 18:27:08 GMT-0400 (EDT): mozstd-trackwhite-digest256 ==> a
listmanager: 18:27:08 GMT-0400 (EDT): goog-badbinurl-shavar ==> a
listmanager: 18:27:08 GMT-0400 (EDT): test-track-simple ==> a
listmanager: 18:27:08 GMT-0400 (EDT): base-track-digest256 ==> a
listmanager: 18:27:08 GMT-0400 (EDT): test-malware-simple ==> a
listmanager: 18:27:08 GMT-0400 (EDT): goog-malware-shavar ==> a
listmanager: 18:27:08 GMT-0400 (EDT): goog-unwanted-shavar ==> a
listmanager: 18:27:08 GMT-0400 (EDT): goog-phish-shavar ==> a
listmanager: 18:27:08 GMT-0400 (EDT): test-unwanted-simple ==> a
listmanager: 18:27:08 GMT-0400 (EDT): mozplugin-block-digest256 ==> a
listmanager: 18:27:08 GMT-0400 (EDT): test-block-simple ==> a
listmanager: 18:27:08 GMT-0400 (EDT): test-phish-simple ==> a
listmanager: 18:27:08 GMT-0400 (EDT): goog-malware-proto ==> Cg0IARAGGAEiAzAwMTABEMehARoCGAUgLHMd
listmanager: 18:27:08 GMT-0400 (EDT): googpub-phish-proto ==> Cg0IAhAGGAEiAzAwMTABEIieARoCGAXkh2Jf
listmanager: 18:27:08 GMT-0400 (EDT): goog-unwanted-proto ==> Cg0IAxAGGAEiAzAwMTABEJuJARoCGAW5gY5F

We should suppress these if we can.

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1312888 - Fix incorrect debug output for V2 lists.

Review commit: https://reviewboard.mozilla.org/r/148882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148882/

Comment 2

[Henry Chang [:hchang]]

Comment on attachment 8877458 [details]
Bug 1312888 - Fix incorrect debug output for V2 lists.

https://reviewboard.mozilla.org/r/148882/#review153486

Simple but helpful! Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae1c97d0941e
Fix incorrect debug output for V2 lists. r=hchang

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ae1c97d0941e