1312989 - Get rid of SetDocumentTitleTransaction because we don't have enough reason to be able to undo-aware of document title change

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, calling nsIHTMLEditor.setDocumentTitle() can change the document's title and make it undoable.

However, I don't think it's worthwhile to be able to undo it.

First, it's not changeable in the editable document, it needs a UI to change it. Actually, mail composing window has a textbox for it and Composer of SeaMonkey has a dialog for it.  Additionally, mail composing window does set document title only when it saves the message. So, undoing title is available only in Composer of SeaMonkey.

Second, undoing document title change isn't unclear what occurs with pressing Ctrl+Z.  When you type something in Composer of SeaMonkey, then, set document title with dialog and type something again in Composer, the first undo removes the last input characters (after closing the dialog to input document title), then, second undo restores old document title, finally, the third undo removes the inputted character before setting the document title.  In this case, user must see the editor, but it doesn't provide any feedback to the user.  Additionally, by a bug of Composer, the document title displayed in the title bar isn't modified by undo/redo.

Finally, I don't think users want to undo/redo document title change when editor has focus. I believe that when they want to change the title again, they must open the dialog again.


Asking ni? for the guys working on Thunderbird and Composer of SeaMonkey. Do you agree with removing undo/redo support of document title change?

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Note that I want to do it after 52 since 52 will be next ESR, so, I don't want this risky change for now.

Comment 2

[Jorg K (CEST = GMT+2)]

We use editor.setDocumentTitle(title); a few times here
https://dxr.mozilla.org/comm-central/search?q=setDocumentTitle&redirect=false
but it doesn't need to be undo-able.

I haven't seen Neil in ages, so I'm forwarding this to Ian.

Comment 3

[Jorg K (CEST = GMT+2)]

Masayuki-san, did you forget about this bug? You fixed this in bug 1312991, right?

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Ah, yes. Thank you.

Comment 5

[Jorg K (CEST = GMT+2)]

Fixed by bug 1312991, hence Target Milestone mozilla53.