Closed Bug 1313040 Opened 3 years ago Closed 3 years ago

Update the list of ignored directories/files with clang-format

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As part of the work in bug 1274087, I would like to ignore more directories.
Comment on attachment 8804632 [details]
Bug 1313040 - Update the list of ignored directories/files with clang-format

https://reviewboard.mozilla.org/r/88548/#review92718

::: .clang-format-ignore:1
(Diff revision 2)
> -^mfbt/.*
> -^js/.*
> -^media/.*
> +^build/clang-plugin/tests/.*
> +^config/gcc-stl-wrapper.template.h
> +^config/msvc-stl-wrapper.template.h

I assume that the subdirectories within these paths are the actual paths we wanted to ignore (like media/libav), and that we don't need to the directories wholesale anymore?

::: .clang-format-ignore:27
(Diff revision 2)
> +^gfx/ycbcr/.*
> +^intl/hyphenation/hyphen/.*
> +^intl/icu/.*
> +^ipc/chromium/.*
> +^js/src/ctypes/libffi/.*
> +^js/src/dtoa.c.*

The `.c.*` seems unnecessary, but it's probably fine to keep it around in order to make this list easily generated from the ThirdPartyPaths.txt file.
Attachment #8804632 - Flags: review?(michael) → review+
Comment on attachment 8804632 [details]
Bug 1313040 - Update the list of ignored directories/files with clang-format

https://reviewboard.mozilla.org/r/88548/#review92718

> I assume that the subdirectories within these paths are the actual paths we wanted to ignore (like media/libav), and that we don't need to the directories wholesale anymore?

This file is actually NOT used by clang-format itself. It is used by filterdiff (tools/mach_commands.py / l272)
And the doc suggests that it will ignore all:

-I FILE, --include-from-file=FILE
           Include only files matching any pattern listed in FILE, one pattern
           per line. All other lines in the input are suppressed.

> The `.c.*` seems unnecessary, but it's probably fine to keep it around in order to make this list easily generated from the ThirdPartyPaths.txt file.

thanks :)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f9e3ba92278
Update the list of ignored directories/files with clang-format r=mystor
https://hg.mozilla.org/mozilla-central/rev/9f9e3ba92278
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.