Closed Bug 1313112 Opened 7 years ago Closed 7 years ago
Deprecate and remove Array
Another "generic" function that was added to the constructor. I think this method is relatively unknown, because it's not documented on MDN and almost nobody really needs to work on ArrayBuffers. We should land a warning in this cycle and then remove it in the next cycle.
Summary: Deprecate and remove ArrayBuffers.slice → Deprecate and remove ArrayBuffer.slice
Jukka, are you using this? I ask because you made some noises about SharedArrayBuffer's slice (though that could have been the instance method, not the static method).
It's not about prototype's property that's in the MDN page, but constructor's property. so, literally "ArrayBuffer.slice".
Yes, importantly: ArrayBuffer.prototype.slice is in Ecma262 SharedArrayBuffer.prototype.slice is in the SAB+Atomics proposal (and now in Firefox) ArrayBuffer.slice is a Firefox-only static method with a different signature; a dead-end feature There is no SharedArrayBuffer.slice
Thanks, that makes sense. Yeah, we don't use ArrayBuffer.slice(myBuffer, ...), but only myBuffer.slice(...), so removing the static version sounds ok to me.
The warning patch landed in 52, should we risk removing this in 53?
Posted the site compatibility doc: https://www.fxsitecompat.com/en-CA/docs/2016/arraybuffer-slice-will-be-removed/
I haven't actually tested this, because of my laptop situation, but I am pretty optimistic this will work.
Attachment #8817697 - Flags: review?(arai.unmht)
Comment on attachment 8817697 [details] [diff] [review] Remove non-standard static ArrayBuffers.slice (not ArrayBuffer.prototype.slice) Review of attachment 8817697 [details] [diff] [review]: ----------------------------------------------------------------- looks good :)
Attachment #8817697 - Flags: review?(arai.unmht) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/26d101a9edac Remove non-standard static ArrayBuffers.slice. r=arai
You need to log in before you can comment on or make changes to this bug.