Closed Bug 1313125 Opened 3 years ago Closed 3 years ago

Get rid of synchronous message from AppsServiceChild.jsm in DOMApplicationRegistry.init

Categories

(Core Graveyard :: DOM: Apps, defect)

50 Branch
defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file)

We send a synchronous message when initting DOMApplicationRegistry right here:

http://searchfox.org/mozilla-central/rev/8cf1367dd89cc36ef8f025dfc6af6d5c086838a7/dom/apps/AppsServiceChild.jsm#111

This is showing up in the stacks that we're getting for things that are blocking or slowing down tab switch and are contributing to tab switch spinners.

We're getting of dom/apps anyways (bug 1291291), but that's a longer process. Perhaps we can kinda just remove this message since I don't think Desktop cares about the DOM Apps API anyways?
What's pulling in AppsServiceChild.jsm on desktop? I would just remove that.
(In reply to [:fabrice] Fabrice Desré from comment #1)
> What's pulling in AppsServiceChild.jsm on desktop? I would just remove that.

Looks like the AppsService.js constructor[1] does this in the child, so any code that interacts with nsIAppsService would likely trigger it.

[1]: https://dxr.mozilla.org/mozilla-central/source/dom/apps/AppsService.js#29
It looks like nobody is even responding to the synchronous message. The original responder (Webapps.jsm), was removed in bug 1261019.

As a quick win here (without getting involved in the noble effort to get rid of dom/apps), I think we can safely just get rid of the synchronous message.
Assignee: nobody → mconley
Comment on attachment 8807238 [details]
Bug 1313125 - Get rid of needless synchronous message from AppsServiceChild.jsm.

https://reviewboard.mozilla.org/r/90466/#review90178

Thanks, this cleanup looks good to me!
Attachment #8807238 - Flags: review?(jryans) → review+
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4b8da9a408a1
Get rid of needless synchronous message from AppsServiceChild.jsm. r=jryans
https://hg.mozilla.org/mozilla-central/rev/4b8da9a408a1
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.