1313130 - E10s: Hovering Over <Select> and pressing Backspace Navigates to Previous Page

Status: VERIFIED FIXED

(Toolkit :: Form Manager, defect)

Description

[Justin [:JW_SoftvisionQA]]

STR:
Pre-Req
Have a previous page
1. Navigate to https://people.mozilla.org/~mnoorenberghe/w3c_notifications.htm
2. Click the Direction datalist
3. Hover over a selection
4. Press Backspace

Expected:
The datalist popup is closed

Actual:
Browser Navigates to previous page

This is e10s specific. When e10s = False, the datalist popup stays open.

All Windows Platforms are affected
Ubuntu is not affected

Comment 1

[Justin [:JW_SoftvisionQA]]

mozregression --bad 9-18-2015 --good 9-17-2016

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e7d613b3bcfe1e865378bfac37de64560d1234ec&tochange=11dc79e232110ba6de5179e46dfbda77b52a88c3

I suspect bug 1191897 is what caused this regression.

Neil I see you worked on bug 1191897. Is this the intended functionality?

Comment 2

[Neil Deakin]

I don't think it was intended or not intended. Should be easy enough to add a special case for the backspace key here.

Comment 3

[Andrew Overholt [:overholt]]

Neil, David said to assign this to you :)

Comment 4

[Neil Deakin]

Attachment: Modify menu shortcut handling a bit

This patch removes ignorekeys="handled" and switches to ignorekeys="shortcuts".

The old behaviour was to not call preventDefault on keys that the menu handled itself. However, I don't think that is quite what we wanted to fix 1191897, as it causes different behaviour when you press a key that matches a menu label versus a key that doesn't.

Instead, I switch to a different behaviour which doesn't call preventDefault only when the accelerator key is down.

Comment 5

[Neil Deakin]

https://hg.mozilla.org/integration/mozilla-inbound/rev/70791e56e69ae0ce66c430a6e453eff5aeeef09e
Bug 1313130, change menu shortcut handling so that Windows does not call preventDefault only when the accelerator key is down rather than when a key isn't handled, r=ksteuber

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/70791e56e69a

Comment 7

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Too late to fix in 50.1.0 release

Comment 8

[Justin [:JW_SoftvisionQA]]

I can verify this is fixed on the current nightly.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora/Beta approval on this when you get a chance.

Comment 10

[Neil Deakin]

Comment on attachment 8814156 [details] [diff] [review]
Modify menu shortcut handling a bit

Approval Request Comment
[Feature/Bug causing the regression]:1191897
[User impact if declined]:better handling of keyboard shortcuts when a select popup is open
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:no
[Is the change risky?]:no
[Why is the change risky/not risky?]: improved version of 1191897
[String changes made/needed]:no

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 8814156 [details] [diff] [review]
Modify menu shortcut handling a bit

menu shortcut handling fix, aurora52+

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/eb0973de87ee

Comment 13

[Andrei Vaida [:avaida]]

Setting qe-verify- based on Comment 10.