Closed
Bug 1313197
Opened 8 years ago
Closed 8 years ago
Open source in new tab if it doesn't exist in debugger
Categories
(DevTools :: Debugger, defect, P1)
DevTools
Debugger
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: jlong, Assigned: jlong)
References
Details
Attachments
(1 file)
|
4.68 KB,
patch
|
jlast
:
review+
|
Details | Diff | Splinter Review |
The new debugger has a regression from the old one: if another tool tells it to open a source that it doesn't have (which can happen in various edge cases), it will just be blank. The old debugger opened a view-source: tab to show the source. We should fix it.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8804904 -
Flags: review?(jlaster)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jlong
Priority: -- → P1
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8804904 [details] [diff] [review] 1313197.patch Review of attachment 8804904 [details] [diff] [review]: ----------------------------------------------------------------- Looks good.
Attachment #8804904 -
Flags: review?(jlaster) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=47a27dd3f7a698931ae50ee389c8d34da1db20b6
Pushed by jlong@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4cde141bbedf open source in new tab if it doesn't exist in the debugger r=jlast
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4cde141bbedf
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•