1313198 - Ship legacy copy of the loader behind a pref in 50

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1313198: Bundle a fallback version of the SDK loader behind a preference.

Review commit: https://reviewboard.mozilla.org/r/88736/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88736/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8804907 [details]
Bug 1313198: Bundle a fallback version of the SDK loader behind a preference.

https://reviewboard.mozilla.org/r/88736/#review87828

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8804907 [details]
Bug 1313198: Bundle a fallback version of the SDK loader behind a preference.

Approval Request Comment
[Feature/regressing bug #]: Bug 1309350
[User impact if declined]: This allows us to easily unship changes to the SDK loader if they cause serious regressions.
[Describe test coverage new/current, TreeHerder]: Loader tests can be run with either version of the loader by flipping a pref.
[Risks and why]: Low. The changes involved are trivial.
[String/UUID change made/needed]: None.

Comment 4

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8804907 [details]
Bug 1313198: Bundle a fallback version of the SDK loader behind a preference.

We need this as a mitigation strategy to undo this change on release audience using a system add-on if needed, Beta50+

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e9d836ec5570