131321 - [SEEN] Wildcards for !seen command

Status: VERIFIED FIXED

(Webtools Graveyard :: Mozbot, enhancement, P3)

Description

[Hixie (not reading bugmail)]

<honeypea> can the !seen do wildcard stuff?
<honeypea> it couldnt for infobot, unlike eggdrop
<honeypea> oh yes definitely if you can
<honeypea> like "!seen honey*"
<honeypea> VERY popular

Comment 1

[Dave Miller [:justdave]]

Attachment: Real patch

Comment 2

[Dave Miller [:justdave]]

Attachment: no-whitespace patch for review purposes

This patch is with diff -w for review purposes, since 90% of the real patch is
an indent shift.

Comment 3

[Dave Miller [:justdave]]

Attachment: Real patch v2

oops, previous patch has a fall-through problem if there's no matching nicks.

Comment 4

[Dave Miller [:justdave]]

Attachment: no-whitespace patch v2

Comment 5

[Hixie (not reading bugmail)]

Comment on attachment 141664 [details] [diff] [review]
no-whitespace patch v2

>+        my $regexp = quotemeta(lc $who);

There's a sanitizeRegexp (or something) function in the bot API you can use
which will return back a regexp if it is valid and quote it otherwise. Use
that, that way people can use regexps too.

(If you do decide to use this, remove the lc from this call, and put a /i on
the grep regexp later. That way ridiculously geeky people can use perl (?-i) in
their regexp to get case sensitive matches.)


>+        $regexp =~ s/\\\*/.*/g; # replace the escaped * from [...]

This would then fail on regexp patterns like "foo\\*", unfortunately (to catch
users called foo, foo\, foo\\, foo\\\), so maybe not supporting regexps is
fine.

>+        if (10 < @nicksToList) { # if it's more than 10

Use @nicksToList > 10. And make it a configurable number of lines, since
different people have different thresholds of how many lines they want output
to the channel. (10 is quite a bit... default to 4 or 5?)

>+        } elsif (0 < @nicksToList) {

Use @nicksToList > 0.


	    my $n = '';
	    if ($who =~ /^[aeiou]/o) {
		$n = 'n';
	    }
	    $self->say($event, "I've never seen a$n '$who', sorry.");

Change this so it says "I've never seen anyone matching the pattern '$who',
sorry." instead.


Great patch though, these are just minor nits. Note that at some point I want
to split Greeting.bm into Greeting.bm for the fun stuff and Seen.bm for the
!seen stuff. If you feel an urge to do this after you're done with this patch,
I'm not going to stop you. In fact I would sit on the sidelines cheering. :-)

Comment 6

[Hixie (not reading bugmail)]

I'd love to get this into 2.6.

Comment 7

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Seen.bm

My Perl skills are a bit rusty, so this may not be the best way to do it. I noticed that nicks are stored in lowercase, so this ignores case and any specified modes. Since this is also a new standalone module, I'll file a new bug on removing the !seen bits from Greeting.bm.

Comment 8

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Attachment: Seen.bm v2

Did I mention my regex-fu stinks as well? ;)

Comment 9

[Wolf [:wolf]]

Comment on attachment 226034 [details]
Seen.bm v2

Woo. This would've been much easier to review as a seperate wildcards then a seperate seen out of greeting patch, but oh well.
Looks like the review comments from the previous iteration were addressed (regexp problem, nicksToList being configurable, etc, and testing doesn't reveal any problems.

Comment 10

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/webtools/mozbot/BotModules/Seen.bm 1.1

Comment 11

[Tanner M. Young [:tmyoung]]

Verified Fixed.