Empty username and/or credential in RTCPeerConnection constructor throw when they shouldn't

RESOLVED FIXED in Firefox 52

Status

()

Core
WebRTC
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jib, Assigned: jib)

Tracking

Trunk
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

STR:
 1. In web console, type:

> new RTCPeerConnection({ iceServers: [{ urls: "turn:turn.example.org", username: "", credential: "" }] })

Expected result (according to spec [1]):
> RTCPeerConnection {  }

Actual result:
> InvalidAccessError: RTCPeerConnection constructor passed invalid RTCConfiguration - missing username: turn:turn.example.org

This must be fixed to pass web platform tests. [2]

[1] https://github.com/w3c/webrtc-pc/issues/885
[2] https://github.com/w3c/web-platform-tests/pull/4071
Comment hidden (mozreview-request)

Comment 2

2 years ago
Comment on attachment 8804948 [details]
Bug 1313246 - allow empty username and credential in RTCPeerConnection constructor.

Redirecting to Byron
Attachment #8804948 - Flags: review?(ekr) → review?(docfaraday)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8804948 [details]
Bug 1313246 - allow empty username and credential in RTCPeerConnection constructor.

https://reviewboard.mozilla.org/r/88758/#review88096
Attachment #8804948 - Flags: review?(docfaraday) → review+

Comment 4

2 years ago
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b9851671ac00
allow empty username and credential in RTCPeerConnection constructor. r=bwc

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b9851671ac00
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.