Closed
Bug 1313293
Opened 8 years ago
Closed 8 years ago
stylo: Implement CSSStyleSheet.insertRule and deleteRule
Categories
(Core :: DOM: CSS Object Model, defect, P1)
Core
DOM: CSS Object Model
Tracking
()
RESOLVED
FIXED
mozilla53
Tracking | Status | |
---|---|---|
firefox53 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Updated•8 years ago
|
Component: CSS Parsing and Computation → DOM: CSS Object Model
Comment 1•8 years ago
|
||
Sounds like P1, according to the priority of bug 1281962?
Flags: needinfo?(xidorn+moz)
Assignee | ||
Comment 2•8 years ago
|
||
Yeah, if the whole project is P1, then this is certainly P1.
Flags: needinfo?(xidorn+moz)
Updated•8 years ago
|
Priority: -- → P1
Assignee | ||
Comment 3•8 years ago
|
||
This now depends on servo/servo#14355 and I would create another pr to remove the extra layer of CssRules...
Assignee | ||
Comment 4•8 years ago
|
||
It now depends on servo/servo#14384 and servo/servo#14385.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → xidorn+moz
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8814807 [details] Bug 1313293 - Implement CSSStyleSheet.insertRule and deleteRule. https://reviewboard.mozilla.org/r/95906/#review96282 ::: layout/style/ServoStyleSheet.cpp:177 (Diff revision 1) > + aRv = mRuleList->DeleteRule(aIndex); > + if (!aRv.Failed() && mDocument) { Is it worth asserting in here that the nsresult we get back isn't NS_ERROR_DOM_INDEX_SIZE_ERR, since that should have been handled above?
Attachment #8814807 -
Flags: review?(cam) → review+
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/19f0a7a2be14 Implement CSSStyleSheet.insertRule and deleteRule. r=heycam
Assignee | ||
Comment 8•8 years ago
|
||
https://github.com/servo/servo/pull/14406
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/19f0a7a2be14
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 10•8 years ago
|
||
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/18cd502c7f01 followup - Fix small issue of ServoCSSRuleList::InsertRule.
Comment 11•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/18cd502c7f01
Updated•7 years ago
|
status-firefox52:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•