stylo: Implement CSSStyleSheet.insertRule and deleteRule

RESOLVED FIXED in Firefox 53

Status

()

defect
P1
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: xidorn, Assigned: xidorn)

Tracking

Trunk
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

No description provided.
Component: CSS Parsing and Computation → DOM: CSS Object Model
Depends on: 1314208
Sounds like P1, according to the priority of bug 1281962?
Flags: needinfo?(xidorn+moz)
Yeah, if the whole project is P1, then this is certainly P1.
Flags: needinfo?(xidorn+moz)
Priority: -- → P1
This now depends on servo/servo#14355 and I would create another pr to remove the extra layer of CssRules...
It now depends on servo/servo#14384 and servo/servo#14385.
Assignee: nobody → xidorn+moz
Comment on attachment 8814807 [details]
Bug 1313293 - Implement CSSStyleSheet.insertRule and deleteRule.

https://reviewboard.mozilla.org/r/95906/#review96282

::: layout/style/ServoStyleSheet.cpp:177
(Diff revision 1)
> +  aRv = mRuleList->DeleteRule(aIndex);
> +  if (!aRv.Failed() && mDocument) {

Is it worth asserting in here that the nsresult we get back isn't NS_ERROR_DOM_INDEX_SIZE_ERR, since that should have been handled above?
Attachment #8814807 - Flags: review?(cam) → review+
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/19f0a7a2be14
Implement CSSStyleSheet.insertRule and deleteRule. r=heycam
https://hg.mozilla.org/mozilla-central/rev/19f0a7a2be14
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Pushed by xquan@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18cd502c7f01
followup - Fix small issue of ServoCSSRuleList::InsertRule.
Depends on: 1336863
You need to log in before you can comment on or make changes to this bug.