1313293 - stylo: Implement CSSStyleSheet.insertRule and deleteRule

Status: RESOLVED FIXED

(Core :: DOM: CSS Object Model, defect, P1)

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Sounds like P1, according to the priority of bug 1281962?

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Yeah, if the whole project is P1, then this is certainly P1.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

This now depends on servo/servo#14355 and I would create another pr to remove the extra layer of CssRules...

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

It now depends on servo/servo#14384 and servo/servo#14385.

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1313293 - Implement CSSStyleSheet.insertRule and deleteRule.

Review commit: https://reviewboard.mozilla.org/r/95906/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95906/

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8814807 [details]
Bug 1313293 - Implement CSSStyleSheet.insertRule and deleteRule.

https://reviewboard.mozilla.org/r/95906/#review96282

::: layout/style/ServoStyleSheet.cpp:177
(Diff revision 1)
> +  aRv = mRuleList->DeleteRule(aIndex);
> +  if (!aRv.Failed() && mDocument) {

Is it worth asserting in here that the nsresult we get back isn't NS_ERROR_DOM_INDEX_SIZE_ERR, since that should have been handled above?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/19f0a7a2be14
Implement CSSStyleSheet.insertRule and deleteRule. r=heycam

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

https://github.com/servo/servo/pull/14406

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/19f0a7a2be14

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/18cd502c7f01
followup - Fix small issue of ServoCSSRuleList::InsertRule.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/18cd502c7f01