1313362 - Convert nsGenConList to use mozilla::LinkedList

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

nsGenConNode should inherit from mozilla::LinkedListElement<nsGenConNode>, and nsGenConList should use a mozilla::LinkedList<nsGenConNode> instead of manually allocating mFirstNode.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList.

Review commit: https://reviewboard.mozilla.org/r/88950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88950/

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8805101 [details]
Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88950/diff/1-2/

Comment 3

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8805101 [details]
Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88950/diff/2-3/

Comment 4

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8805101 [details]
Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88950/diff/3-4/

Comment 5

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8805101 [details]
Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList.

https://reviewboard.mozilla.org/r/88950/#review88674

::: layout/base/nsGenConList.h:124
(Diff revision 4)
> +
>  private:
>    void Destroy(nsGenConNode* aNode)
>    {
> -    PR_REMOVE_LINK(aNode);
> +    MOZ_ASSERT(aNode, "aNode cannot be nullptr!");
> +    aNode->remove();

You don't really need this. LinkedListElement's destructor removes itself automatically.

Comment 6

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8805101 [details]
Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList.

https://reviewboard.mozilla.org/r/88950/#review88674

> You don't really need this. LinkedListElement's destructor removes itself automatically.

You're right!

Comment 7

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Comment on attachment 8805101 [details]
Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/88950/diff/4-5/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c73b60315c75
Convert nsGenConList to use mozilla::LinkedList. r=xidorn

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c73b60315c75