Closed Bug 1313362 Opened 3 years ago Closed 3 years ago

Convert nsGenConList to use mozilla::LinkedList

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

nsGenConNode should inherit from mozilla::LinkedListElement<nsGenConNode>, and nsGenConList should use a mozilla::LinkedList<nsGenConNode> instead of manually allocating mFirstNode.
Attachment #8805101 - Flags: review?(xidorn+moz)
Comment on attachment 8805101 [details]
Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList.

https://reviewboard.mozilla.org/r/88950/#review88674

::: layout/base/nsGenConList.h:124
(Diff revision 4)
> +
>  private:
>    void Destroy(nsGenConNode* aNode)
>    {
> -    PR_REMOVE_LINK(aNode);
> +    MOZ_ASSERT(aNode, "aNode cannot be nullptr!");
> +    aNode->remove();

You don't really need this. LinkedListElement's destructor removes itself automatically.
Attachment #8805101 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8805101 [details]
Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList.

https://reviewboard.mozilla.org/r/88950/#review88674

> You don't really need this. LinkedListElement's destructor removes itself automatically.

You're right!
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c73b60315c75
Convert nsGenConList to use mozilla::LinkedList. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/c73b60315c75
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.