Closed
Bug 1313362
Opened 8 years ago
Closed 8 years ago
Convert nsGenConList to use mozilla::LinkedList
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: TYLin, Assigned: TYLin)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
nsGenConNode should inherit from mozilla::LinkedListElement<nsGenConNode>, and nsGenConList should use a mozilla::LinkedList<nsGenConNode> instead of manually allocating mFirstNode.
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8805101 -
Flags: review?(xidorn+moz)
| Comment hidden (mozreview-request) |
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8805101 [details] Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList. https://reviewboard.mozilla.org/r/88950/#review88674 ::: layout/base/nsGenConList.h:124 (Diff revision 4) > + > private: > void Destroy(nsGenConNode* aNode) > { > - PR_REMOVE_LINK(aNode); > + MOZ_ASSERT(aNode, "aNode cannot be nullptr!"); > + aNode->remove(); You don't really need this. LinkedListElement's destructor removes itself automatically.
Attachment #8805101 -
Flags: review?(xidorn+moz) → review+
|
|
Assignee | |
Comment 6•8 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8805101 [details] Bug 1313362 - Convert nsGenConList to use mozilla::LinkedList. https://reviewboard.mozilla.org/r/88950/#review88674 > You don't really need this. LinkedListElement's destructor removes itself automatically. You're right!
| Comment hidden (mozreview-request) |
Pushed by tlin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c73b60315c75 Convert nsGenConList to use mozilla::LinkedList. r=xidorn
|
||
Comment 9•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c73b60315c75
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•