1313386 - Clean up the beforeprint/afterprint event dispatching code

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Jonathan Watt [:jwatt]]

I have a patch to clean up the beforeprint/afterprint event dispatching code a little. Mostly it's a little about removing some unnecessary clutter from nsDocumentViewer's interface, but it also changing names to make it a bit clearer what's happening when skimming the code (adds "Auto" to names to make the RAII behavior clearer) and adds some documentation and links.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8805152 [details] [diff] [review]
patch

Review of attachment 8805152 [details] [diff] [review]:
-----------------------------------------------------------------

r=me -- one requested followup:

::: layout/base/nsDocumentViewer.cpp
@@ +423,5 @@
> +    DispatchEventToWindowTree(mTop, NS_LITERAL_STRING("afterprint"));
> +  }
> +
> +private:
> +  static void DispatchEventToWindowTree(nsIDocument* aDoc,

Now that this is "private", and the callers always pass "mDoc" as the aDoc arg:  could you simplify this to make it non-static and just have it use |mDoc| directly?

(This probably belongs in a "part 2" patch, so that this first patch can have the nice property that it's just renaming/moving code without rewriting stuff at the same time.)

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8805152 [details] [diff] [review]
patch

(Sorry, I meant to grant r+, not r-)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2d98eac568db
part 1 - Clean up the beforeprint/afterprint event dispatching code. r=dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/23f27301062d
part 2 - Make AutoPrintEventDispatcher::DispatchEventToWindowTree non-static. r=dholbert

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2d98eac568db
https://hg.mozilla.org/mozilla-central/rev/23f27301062d