1313517 - ADTS demuxer incorrectly set to not calculate start time

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

ADTSDemuxer::ShouldComputeStartTime returns false. This is incorrect. Start time should only not be calculated with MSE

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1313517: Always compute start time with ADTS.

This was originally copied from the MP3Demuxer and was only required to work around an issue now fixed.
Only MSE should set ShoultComputeStartTime to false, even if the ADTS demuxer always returns a first sample with a time of 0.

Review commit: https://reviewboard.mozilla.org/r/89050/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89050/

Comment 2

[u480271]

Comment on attachment 8805283 [details]
Bug 1313517: Always compute start time with ADTS.

https://reviewboard.mozilla.org/r/89050/#review88266

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/011fe8bad1eb
Always compute start time with ADTS. r=kamidphish

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/011fe8bad1eb