1313565 - Convert NS_STYLE_USER_MODIFY, NS_STYLE_WINDOW_DRAGGING and NS_STYLE_ORIENT to enum classes

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Adam Velebil]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:50.0) Gecko/20100101 Firefox/50.0
Build ID: 20161024172922

Comment 1

[Adam Velebil]

Attachment: Bug 1313565 - Convert NS_STYLE_USER_MODIFY_* to enum class ;

Review commit: https://reviewboard.mozilla.org/r/89168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89168/

Comment 2

[Adam Velebil]

Attachment: Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ;

Review commit: https://reviewboard.mozilla.org/r/89170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89170/

Comment 3

[Adam Velebil]

Attachment: Bug 1313565 - Convert NS_STYLE_ORIENT_* to enum class ;

Review commit: https://reviewboard.mozilla.org/r/89172/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89172/

Comment 4

[Manish Goregaokar [:manishearth]]

Comment on attachment 8805433 [details]
Bug 1313565 - Convert NS_STYLE_USER_MODIFY_* to enum class ;

https://reviewboard.mozilla.org/r/89168/#review88590

Comment 5

[Manish Goregaokar [:manishearth]]

Comment on attachment 8805434 [details]
Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ;

https://reviewboard.mozilla.org/r/89170/#review88594

::: layout/style/nsStyleStruct.h:3316
(Diff revision 1)
>             nsChangeHint_ReflowChangesSizeOrPosition |
>             nsChangeHint_ClearAncestorIntrinsics;
>    }
>  
> -  mozilla::StyleUserSelect mUserSelect;   // [reset] (selection-style)
> -  uint8_t   mForceBrokenImageIcon; // [reset]  (0 if not forcing, otherwise forcing)
> +  mozilla::StyleUserSelect     mUserSelect;     // [reset](selection-style)
> +  uint8_t                      mForceBrokenImageIcon; // [reset]

Since the comment for `mForceBrokenImageIcon` isn't aligned anyway, we can just keep `mForceBrokenImageIcon` unaligned (one space after the `uint8_t`).

Comment 6

[Manish Goregaokar [:manishearth]]

Comment on attachment 8805434 [details]
Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ;

https://reviewboard.mozilla.org/r/89170/#review88596

Comment 7

[Manish Goregaokar [:manishearth]]

Comment on attachment 8805435 [details]
Bug 1313565 - Convert NS_STYLE_ORIENT_* to enum class ;

https://reviewboard.mozilla.org/r/89172/#review88598

Comment 8

[Adam Velebil]

Comment on attachment 8805434 [details]
Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89170/diff/1-2/

Comment 9

[Adam Velebil]

Comment on attachment 8805435 [details]
Bug 1313565 - Convert NS_STYLE_ORIENT_* to enum class ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89172/diff/1-2/

Comment 10

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8805433 [details]
Bug 1313565 - Convert NS_STYLE_USER_MODIFY_* to enum class ;

https://reviewboard.mozilla.org/r/89168/#review88680

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8805434 [details]
Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ;

https://reviewboard.mozilla.org/r/89170/#review88682

Comment 12

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8805435 [details]
Bug 1313565 - Convert NS_STYLE_ORIENT_* to enum class ;

https://reviewboard.mozilla.org/r/89172/#review88684

Comment 13

[Adam Velebil]

Comment on attachment 8805433 [details]
Bug 1313565 - Convert NS_STYLE_USER_MODIFY_* to enum class ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89168/diff/1-2/

Comment 14

[Adam Velebil]

Comment on attachment 8805434 [details]
Bug 1313565 - Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89170/diff/2-3/

Comment 15

[Adam Velebil]

Comment on attachment 8805435 [details]
Bug 1313565 - Convert NS_STYLE_ORIENT_* to enum class ;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89172/diff/2-3/

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6b80fdaeadfc
Convert NS_STYLE_USER_MODIFY_* to enum class ; r=manishearth,xidorn
https://hg.mozilla.org/integration/autoland/rev/cb8c35d77841
Convert NS_STYLE_WINDOW_DRAGGING_* to enum class ; r=manishearth,xidorn
https://hg.mozilla.org/integration/autoland/rev/050803173323
Convert NS_STYLE_ORIENT_* to enum class ; r=manishearth,xidorn

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6b80fdaeadfc
https://hg.mozilla.org/mozilla-central/rev/cb8c35d77841
https://hg.mozilla.org/mozilla-central/rev/050803173323