Closed
Bug 1313585
Opened 8 years ago
Closed 8 years ago
nsGlobalWindow needs to remove the existing gamepads while it is removed by GamepadManager.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: daoshengmu, Assigned: daoshengmu)
Details
Attachments
(2 files)
When we remove listeners in GamepadManager, GamepadManager will try to clear its mGamepads array that is for keeping the existing gamepads. But nsGlobalWindow keeps a mGamepads by itself. So while we reload the global windows. The gamepads will be added duplicate to nsGlobalWindow .
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dmu
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;
https://reviewboard.mozilla.org/r/89246/#review88366
Attachment #8805502 -
Flags: review?(cleu) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8805503 [details]
Bug 1313585 - Part 2: Removing the existing gamepads before scanning VR controllers;
https://reviewboard.mozilla.org/r/89248/#review89362
Attachment #8805503 -
Flags: review?(gwright) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 6•8 years ago
|
||
could you make sure part 1 is also landable via autoland, seems some review-ship-it is needed
Flags: needinfo?(dmu)
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;
https://reviewboard.mozilla.org/r/89246/#review89934
Comment 8•8 years ago
|
||
mozreview-review |
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;
https://reviewboard.mozilla.org/r/89246/#review89936
Attachment #8805502 -
Flags: review+
Comment 9•8 years ago
|
||
Review cancelled because I am unable to set it landable for unknown reason.
Assignee | ||
Comment 10•8 years ago
|
||
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;
Try again for unknown issue on mozreview landable.
Attachment #8805502 -
Flags: review?(cleu)
Comment 11•8 years ago
|
||
mozreview-review |
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;
https://reviewboard.mozilla.org/r/89246/#review89938
re r+ because I am unable to set it landable for unknown reason.
Attachment #8805502 -
Flags: review?(cleu) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 14•8 years ago
|
||
(In reply to Daosheng Mu[:daoshengmu] from comment #12)
> Comment on attachment 8805502 [details]
> Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in
> GamepadManager;
>
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/89246/diff/1-2/
qdot. Because mozreview landable needs a Level 3 reviewer, please help me double review. Thanks.
Flags: needinfo?(dmu)
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 15•8 years ago
|
||
mozreview-review |
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;
https://reviewboard.mozilla.org/r/89246/#review90216
Attachment #8805502 -
Flags: review?(kyle) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 16•8 years ago
|
||
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8502d4f4bb2
Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager; r=lenzak800,qdot
https://hg.mozilla.org/integration/autoland/rev/bafacc3b707c
Part 2: Removing the existing gamepads before scanning VR controllers; r=gw280
Keywords: checkin-needed
Comment 17•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b8502d4f4bb2
https://hg.mozilla.org/mozilla-central/rev/bafacc3b707c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•