nsGlobalWindow needs to remove the existing gamepads while it is removed by GamepadManager.

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: daoshengmu, Assigned: daoshengmu)

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
When we remove listeners in GamepadManager, GamepadManager will try to clear its mGamepads array that is for keeping the existing gamepads. But nsGlobalWindow keeps a mGamepads by itself. So while we reload the global windows. The gamepads will be added duplicate to nsGlobalWindow .
(Assignee)

Updated

2 years ago
Assignee: nobody → dmu
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;

https://reviewboard.mozilla.org/r/89246/#review88366
Attachment #8805502 - Flags: review?(cleu) → review+

Comment 5

2 years ago
mozreview-review
Comment on attachment 8805503 [details]
Bug 1313585 - Part 2: Removing the existing gamepads before scanning VR controllers;

https://reviewboard.mozilla.org/r/89248/#review89362
Attachment #8805503 - Flags: review?(gwright) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
could you make sure part 1 is also landable via autoland, seems some review-ship-it is needed
Flags: needinfo?(dmu)

Comment 7

2 years ago
mozreview-review
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;

https://reviewboard.mozilla.org/r/89246/#review89934

Comment 8

2 years ago
mozreview-review
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;

https://reviewboard.mozilla.org/r/89246/#review89936
Attachment #8805502 - Flags: review+
Review cancelled because I am unable to set it landable for unknown reason.
(Assignee)

Comment 10

2 years ago
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;

Try again for unknown issue on mozreview landable.
Attachment #8805502 - Flags: review?(cleu)

Comment 11

2 years ago
mozreview-review
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;

https://reviewboard.mozilla.org/r/89246/#review89938

re r+ because I am unable to set it landable for unknown reason.
Attachment #8805502 - Flags: review?(cleu) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 14

2 years ago
(In reply to Daosheng Mu[:daoshengmu] from comment #12)
> Comment on attachment 8805502 [details]
> Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in
> GamepadManager;
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/89246/diff/1-2/

qdot. Because mozreview landable needs a Level 3 reviewer, please help me double review. Thanks.
Flags: needinfo?(dmu)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
Comment on attachment 8805502 [details]
Bug 1313585 - Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager;

https://reviewboard.mozilla.org/r/89246/#review90216
Attachment #8805502 - Flags: review?(kyle) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 16

2 years ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b8502d4f4bb2
Part 1: Removing gamepads while nsGlobalWindow is removed in GamepadManager; r=lenzak800,qdot
https://hg.mozilla.org/integration/autoland/rev/bafacc3b707c
Part 2: Removing the existing gamepads before scanning VR controllers; r=gw280
Keywords: checkin-needed

Comment 17

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b8502d4f4bb2
https://hg.mozilla.org/mozilla-central/rev/bafacc3b707c
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.