1313625 - Remove nsIScriptableDateFormat [was: Deprecate nsIScriptableDateFormat]

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Jonathan Kew [:jfkthame]]

From bug 1301655 comment 0:
> We shouldn't need to have an XPCOM API like nsIScriptableDateFormat for browser
> UI JS to format dates and times with. Now that the ECMAScript Intl API is
> available, UI JS code should use the ECMAScript Intl API instead of
> nsIScriptableDateFormat so that the nsIScriptableDateFormat legacy API could
> be removed.

That bug is eliminating the existing users of the API in mozilla-central. As there will doubtless be other users as well (comm-central, add-ons, ...), we should explicitly deprecate the interface and point people (through documentation, maybe a console warning?) towards the modern alternative.

Comment 1

[Jonathan Kew [:jfkthame]]

:jorgev, can we check for code that uses nsIScriptableDateFormat in add-ons, and prompt the authors to migrate to Intl.DateTimeFormat instead?

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

I see a number of add-ons using it. The ideal process in this case is to first deprecate the API and show a console warning when it's used. A release or two later, it can be dropped entirely.

We can message the developers for both events.

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Mark nsIScriptableDateFormat as deprecated, and issue a message to the browser console when it is used

This gives us a build-time warning when nsIScriptableDateFormat is compiled (at least on OS X; I'm not sure if all our compilers do that), and a simple runtime message in the browser console when it's used. I didn't make the message localizable, as that seemed like overkill here; I don't think we need to burden localizers with this.

Comment 4

[Zibi Braniecki [:zbraniecki][:gandalf]]

Bug 1354442 is the last in Firefox that uses nsIScriptableDateFormat.

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: Bug 1313625 - Remove nsIScriptableDateFormat.

Review commit: https://reviewboard.mozilla.org/r/164776/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/164776/

Comment 6

[Jonathan Kew [:jfkthame]]

Hmm, looks like we never landed the patch (attachment 8805914 [details] [diff] [review]) that was going to add a deprecation warning. :-( I guess it's a bit late for that now.

Still, maybe we should land it here, and then have a followup in a few weeks to actually remove the code. WDYT?

Comment 7

[Masatoshi Kimura [:emk]]

I think we should not give an illusion that we still keep stability of the internal API even after 57.

Comment 8

[Jorg K (CEST = GMT+2)]

We removed nsIScriptableDateFormat from C-C, so you can remove it any time ;-)

Comment 9

[Jonathan Kew [:jfkthame]]

Comment on attachment 8893675 [details]
Bug 1313625 - Remove nsIScriptableDateFormat.

https://reviewboard.mozilla.org/r/164776/#review170254

Fine, let's do it.

Comment 10

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 2b990ca29826 -d 76dcd1e6797b: rebasing 411597:2b990ca29826 "Bug 1313625 - Remove nsIScriptableDateFormat. r=jfkthame" (tip)
local [dest] changed intl/locale/nsIScriptableDateFormat.idl which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
local [dest] changed intl/locale/nsScriptableDateFormat.cpp which other [source] deleted
use (c)hanged version, (d)elete, or leave (u)nresolved? u
merging intl/build/nsI18nModule.cpp
merging intl/locale/moz.build
merging intl/locale/nsLocaleConstructors.h
warning: conflicts while merging intl/locale/moz.build! (edit, then use 'hg resolve --mark')
warning: conflicts while merging intl/locale/nsLocaleConstructors.h! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 11

[Masatoshi Kimura [:emk]]

Comment on attachment 8893675 [details]
Bug 1313625 - Remove nsIScriptableDateFormat.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/164776/diff/1-2/

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afc4e2d4eb96
Remove nsIScriptableDateFormat. r=jfkthame

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/afc4e2d4eb96

Comment 14

[Masatoshi Kimura [:emk]]

We don't care about (legacy) addon-compat anymore.