1313706 - Enable captive portal detection on all channels

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[(inactive) Nihanth Subramanya [:nhnt11]]

Now that the captive portal notification has landed, we should enable captive portal detection on all release channels and not just Nightly.

Comment 1

[Matthew N. [:MattN]]

[Tracking Requested - why for this release]: Releasing a new feature.

Comment 2

[Julien Cristau [:jcristau]]

tracking this new feature for 52

Comment 3

[(inactive) Nihanth Subramanya [:nhnt11]]

Attachment: Bug 1313706 - Enable captive portal detection on all channels.

Review commit: https://reviewboard.mozilla.org/r/97098/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97098/

Comment 4

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97098/diff/1-2/

Comment 5

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97098/diff/2-3/

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

https://reviewboard.mozilla.org/r/97098/#review97452

Looks good!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/96c519a83bf0
Enable captive portal detection on all channels. r=valentin

Comment 8

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

Approval Request Comment
[User impact if declined]: No automatic captive portal detection
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Prefs on a feature that has been active in Nightly for a while, so that people can test during MozAloha.
[String changes made/needed]: none

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/96c519a83bf0

Comment 10

[Julien Cristau [:jcristau]]

Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

enable captive portal in aurora52

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/23f379faaef5