Closed Bug 1313706 Opened 7 years ago Closed 7 years ago

Enable captive portal detection on all channels

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 53
Tracking Flags:
Tracking Status
firefox51 --- unaffected
firefox52 + fixed
firefox53 --- fixed

People

(Reporter: nhnt11, Assigned: nhnt11)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxprivacy])

Attachments

(1 file)

Bug 1313706 - Enable captive portal detection on all channels.
58 bytes, text/x-review-board-request
valentin
: review+
jcristau
: approval-mozilla-aurora+
Details 
Now that the captive portal notification has landed, we should enable captive portal detection on all release channels and not just Nightly.
[Tracking Requested - why for this release]: Releasing a new feature.
status-firefox51: --- → unaffected
status-firefox53: --- → affected
tracking-firefox52: --- → ?
tracking this new feature for 52
tracking-firefox52: ? → +
Assignee: nobody → nhnt11
Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

https://reviewboard.mozilla.org/r/97098/#review97452

Looks good!
Attachment #8816331 - Flags: review?(valentin.gosu) → review+
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/96c519a83bf0
Enable captive portal detection on all channels. r=valentin
Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

Approval Request Comment
[User impact if declined]: No automatic captive portal detection
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Prefs on a feature that has been active in Nightly for a while, so that people can test during MozAloha.
[String changes made/needed]: none
Attachment #8816331 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/96c519a83bf0
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

enable captive portal in aurora52
Attachment #8816331 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.