Enable captive portal detection on all channels

RESOLVED FIXED in Firefox 52

Status

()

Firefox
General
RESOLVED FIXED
6 months ago
5 months ago

People

(Reporter: nhnt11, Assigned: nhnt11)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox51 unaffected, firefox52+ fixed, firefox53 fixed)

Details

(Whiteboard: [fxprivacy])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Now that the captive portal notification has landed, we should enable captive portal detection on all release channels and not just Nightly.
[Tracking Requested - why for this release]: Releasing a new feature.
status-firefox51: --- → unaffected
status-firefox53: --- → affected
tracking-firefox52: --- → ?
tracking this new feature for 52
tracking-firefox52: ? → +
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Assignee: nobody → nhnt11
Comment hidden (mozreview-request)
Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

https://reviewboard.mozilla.org/r/97098/#review97452

Looks good!
Attachment #8816331 - Flags: review?(valentin.gosu) → review+

Comment 7

5 months ago
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/96c519a83bf0
Enable captive portal detection on all channels. r=valentin
(Assignee)

Comment 8

5 months ago
Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

Approval Request Comment
[User impact if declined]: No automatic captive portal detection
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Prefs on a feature that has been active in Nightly for a while, so that people can test during MozAloha.
[String changes made/needed]: none
Attachment #8816331 - Flags: approval-mozilla-aurora?

Comment 9

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/96c519a83bf0
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Comment on attachment 8816331 [details]
Bug 1313706 - Enable captive portal detection on all channels.

enable captive portal in aurora52
Attachment #8816331 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 11

5 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/23f379faaef5
status-firefox52: affected → fixed
You need to log in before you can comment on or make changes to this bug.