1313741 - Convert the DOM test release channel checks to AppConstants

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Ryan VanderMeulen [:RyanVM]]

Right now, test_interfaces.html and some other DOM tests have their own logic for detecting a nightly or release build using a pattern along the lines of SpecialPowers.Cc['@mozilla.org/xre/app-info;1'].getService(SpecialPowers.Ci.nsIXULAppInfo).version followed by some parsing of the returned result.

This release channel functionality is now included in AppConstants.jsm and would be one less reinventing of the wheel in the tree if we converted the tests to use that instead.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Also happens in js/xpconnect/tests/chrome/test_xrayToJS.xul fwiw.

Comment 2

[Andrew Overholt [:overholt]]

I'm assuming P3 here due to the lack of recent activity but feel free to correct me :)

Comment 3

[Ryan VanderMeulen [:RyanVM]]

I'm not going to get to this any time soon. Could be a good second bug perhaps?

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Turns out I need to fix this to avoid test failures once bug 1548655 lands on mozilla-beta.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Green on Try.

Nightly68: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7279d6d41a2db63685480e242635866683c6b9d2
Beta68: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f57903332a4b2755d86f3e1df20ec9162d834b7f

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 1313741 - Use AppConstants in DOM and XPConnect tests instead of manual detection.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51b73cca09ea
Use AppConstants in DOM and XPConnect tests instead of manual detection. r=bzbarsky

Comment 8

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/51b73cca09ea