Closed Bug 1313741 Opened 4 years ago Closed 1 year ago

Convert the DOM test release channel checks to AppConstants

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: RyanVM, Assigned: RyanVM)

References

Details

Attachments

(1 file)

Right now, test_interfaces.html and some other DOM tests have their own logic for detecting a nightly or release build using a pattern along the lines of SpecialPowers.Cc['@mozilla.org/xre/app-info;1'].getService(SpecialPowers.Ci.nsIXULAppInfo).version followed by some parsing of the returned result.

This release channel functionality is now included in AppConstants.jsm and would be one less reinventing of the wheel in the tree if we converted the tests to use that instead.
Assignee: nobody → ryanvm
Also happens in js/xpconnect/tests/chrome/test_xrayToJS.xul fwiw.
I'm assuming P3 here due to the lack of recent activity but feel free to correct me :)
Priority: -- → P3
Component: DOM → DOM: Core & HTML

I'm not going to get to this any time soon. Could be a good second bug perhaps?

Assignee: ryanvm → nobody
Summary: Convert the DOM test release channel checks to AppConstants.jsm → Convert the DOM test release channel checks to AppConstants
Assignee: nobody → ryanvm
Blocks: 1548655

Turns out I need to fix this to avoid test failures once bug 1548655 lands on mozilla-beta.

Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51b73cca09ea
Use AppConstants in DOM and XPConnect tests instead of manual detection. r=bzbarsky
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.