Convert the DOM test release channel checks to AppConstants

RESOLVED FIXED in Firefox 68

Status

()

defect
P3
normal
RESOLVED FIXED
3 years ago
Last month

People

(Reporter: RyanVM, Assigned: RyanVM)

Tracking

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
Right now, test_interfaces.html and some other DOM tests have their own logic for detecting a nightly or release build using a pattern along the lines of SpecialPowers.Cc['@mozilla.org/xre/app-info;1'].getService(SpecialPowers.Ci.nsIXULAppInfo).version followed by some parsing of the returned result.

This release channel functionality is now included in AppConstants.jsm and would be one less reinventing of the wheel in the tree if we converted the tests to use that instead.
Assignee

Updated

3 years ago
Assignee: nobody → ryanvm
Also happens in js/xpconnect/tests/chrome/test_xrayToJS.xul fwiw.
I'm assuming P3 here due to the lack of recent activity but feel free to correct me :)
Priority: -- → P3
Component: DOM → DOM: Core & HTML
Assignee

Comment 3

3 months ago

I'm not going to get to this any time soon. Could be a good second bug perhaps?

Assignee: ryanvm → nobody
Summary: Convert the DOM test release channel checks to AppConstants.jsm → Convert the DOM test release channel checks to AppConstants
Assignee

Updated

Last month
Assignee: nobody → ryanvm
Blocks: 1548655
Assignee

Comment 4

Last month

Turns out I need to fix this to avoid test failures once bug 1548655 lands on mozilla-beta.

Comment 7

Last month
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51b73cca09ea
Use AppConstants in DOM and XPConnect tests instead of manual detection. r=bzbarsky

Comment 8

Last month
bugherder
Status: NEW → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.