Closed Bug 1313794 Opened 3 years ago Closed 3 years ago

Remove Date.prototype.toLocaleFormat uses in browser/modules

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(1 file)

Date.prototype.toLocaleFormat is a non-standard API and we plan to warn when it's used (bug 1299900) and eventually want to remove it completely (bug 818634). As a first step we need to replace all Date.prototype.toLocaleFormat uses in Firefox with standardized APIs.

Date.prototype.toLocaleFormat is used in browser/modules/ContentCrashHandlers.jsm and the accompanying test file browser/modules/test/browser_UnsubmittedCrashHandler.js. In ContentCrashHandlers.jsm, I've replaced toLocaleFormat with standard JavaScript API. In browser_UnsubmittedCrashHandler.js, I've replaced all toLocaleFormat uses with direct calls to UnsubmittedCrashHandler.dateString.
Attachment #8805723 - Flags: review?(felipc)
Attachment #8805723 - Flags: review?(felipc) → review+
Thanks for the prompt review!
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f9d27032d1b
Remove Date.prototype.toLocaleFormat uses in browser/modules. r=Felipe
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6f9d27032d1b
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.