Closed
Bug 1313797
Opened 9 years ago
Closed 9 years ago
Remove Date.prototype.toLocaleFormat uses in toolkit/mozapps/extensions/internal
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file, 1 obsolete file)
|
2.36 KB,
patch
|
anba
:
review+
|
Details | Diff | Splinter Review |
Date.prototype.toLocaleFormat is a non-standard API and we plan to warn when it's used (bug 1299900) and eventually want to remove it completely (bug 818634). As a first step we need to replace all Date.prototype.toLocaleFormat uses in Firefox with standardized APIs.
Date.prototype.toLocaleFormat is used in toolkit/mozapps/extensions/internal/AddonLogging.jsm and could easily be replaced with standard JavaScript API.
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8805726 -
Flags: review?(dtownsend)
|
||
Updated•9 years ago
|
Attachment #8805726 -
Flags: review?(dtownsend) → review+
|
|
Assignee | |
Comment 2•9 years ago
|
||
Original patch only had a place holder bug number, updated patch to use the correct bug number. Carrying r+ from :mossop.
Attachment #8805726 -
Attachment is obsolete: true
Attachment #8806323 -
Flags: review+
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a9993173926
Remove Date.prototype.toLocaleFormat uses in toolkit/mozapps/extensions/internal. r=mossop
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
||
Comment 6•9 years ago
|
||
Thanks André! We've added this patch to our recognition page: https://wiki.mozilla.org/Add-ons/Contribute/Recognition#November_2016
You need to log in
before you can comment on or make changes to this bug.
Description
•