Closed Bug 1313798 Opened 3 years ago Closed 3 years ago

Remove Date.prototype.toLocaleFormat uses in services/sync

Categories

(Firefox :: Sync, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox52 --- fixed

People

(Reporter: anba, Assigned: anba)

References

Details

Attachments

(1 file)

Date.prototype.toLocaleFormat is a non-standard API and we plan to warn when it's used (bug 1299900) and eventually want to remove it completely (bug 818634). As a first step we need to replace all Date.prototype.toLocaleFormat uses in Firefox with standardized APIs.

Date.prototype.toLocaleFormat is used in services/sync/modules/service.js and services/sync/modules/stages/enginesync.js. I've replaced both uses by adding a new helper method to services/sync/modules/util.js, and I've also removed the no longer used format string constant in services/sync/modules/constants.js.
Attachment #8805728 - Flags: review?(rnewman)
Attachment #8805728 - Flags: review?(rnewman) → review+
Priority: -- → P1
Thanks for the prompt review!
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d4a5ed8adf1
Remove Date.prototype.toLocaleFormat uses in services/sync. r=rnewman
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7d4a5ed8adf1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.