Closed Bug 1313834 Opened 4 years ago Closed 4 years ago

Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js

Categories

(Firefox :: Security, defect, P5)

defect

Tracking

()

RESOLVED FIXED
Firefox 53
Iteration:
53.1 - Nov 28
Tracking Status
firefox53 --- fixed

People

(Reporter: johannh, Assigned: catdesk, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [fxprivacy] [good first bug])

Attachments

(1 file)

SpecialPowers.pushPrefEnv returns a Promise, so we can remove the "new Promise(r =>" part of these lines:

http://searchfox.org/mozilla-central/search?q=Promise.*SpecialPowers&regexp=true&path=browser_aboutCertError.js
Summary: Clean up Promise code in browser_aboutCertError.js → Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js
Mentor: jhofmann
I'll work on working on this.
Assignee: nobody → catdesk
Comment on attachment 8805756 [details]
Bug 1313834 - Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js.

https://reviewboard.mozilla.org/r/89440/#review88676

Nice, thank you! I'll do a push to try for you now (https://wiki.mozilla.org/ReleaseEngineering/TryServer) to test that everything is still working correctly.
Attachment #8805756 - Flags: review?(jhofmann) → review+
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f547d674f0c2
Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js. r=johannh
https://hg.mozilla.org/mozilla-central/rev/f547d674f0c2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Iteration: --- → 53.1 - Nov 28
You need to log in before you can comment on or make changes to this bug.