Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Security
P5
normal
RESOLVED FIXED
10 months ago
7 months ago

People

(Reporter: johannh, Assigned: catdesk, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 53
good-first-bug
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [fxprivacy] [good first bug])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

SpecialPowers.pushPrefEnv returns a Promise, so we can remove the "new Promise(r =>" part of these lines:

http://searchfox.org/mozilla-central/search?q=Promise.*SpecialPowers&regexp=true&path=browser_aboutCertError.js
Summary: Clean up Promise code in browser_aboutCertError.js → Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js
Mentor: jhofmann@mozilla.com
(Assignee)

Comment 1

10 months ago
I'll work on working on this.
Assignee: nobody → catdesk
Comment hidden (mozreview-request)
(Reporter)

Comment 3

10 months ago
mozreview-review
Comment on attachment 8805756 [details]
Bug 1313834 - Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js.

https://reviewboard.mozilla.org/r/89440/#review88676

Nice, thank you! I'll do a push to try for you now (https://wiki.mozilla.org/ReleaseEngineering/TryServer) to test that everything is still working correctly.
Attachment #8805756 - Flags: review?(jhofmann) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f58ae14ec899

Comment 5

9 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f547d674f0c2
Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js. r=johannh

Comment 6

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f547d674f0c2
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53

Updated

8 months ago
Iteration: --- → 53.1 - Nov 28
status-firefox52: affected → ---
You need to log in before you can comment on or make changes to this bug.