Closed
Bug 1313834
Opened 8 years ago
Closed 8 years ago
Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js
Categories
(Firefox :: Security, defect, P5)
Firefox
Security
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: johannh, Assigned: catdesk, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [fxprivacy] [good first bug])
Attachments
(1 file)
SpecialPowers.pushPrefEnv returns a Promise, so we can remove the "new Promise(r =>" part of these lines: http://searchfox.org/mozilla-central/search?q=Promise.*SpecialPowers®exp=true&path=browser_aboutCertError.js
|
Reporter | |
Updated•8 years ago
|
Summary: Clean up Promise code in browser_aboutCertError.js → Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js
|
|
Reporter | |
Updated•8 years ago
|
Mentor: jhofmann
|
||
Updated•8 years ago
|
Assignee: nobody → catdesk
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8805756 [details] Bug 1313834 - Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js. https://reviewboard.mozilla.org/r/89440/#review88676 Nice, thank you! I'll do a push to try for you now (https://wiki.mozilla.org/ReleaseEngineering/TryServer) to test that everything is still working correctly.
Attachment #8805756 -
Flags: review?(jhofmann) → review+
|
|
Reporter | |
Comment 4•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f58ae14ec899
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f547d674f0c2 Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js. r=johannh
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f547d674f0c2
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
|
||
Updated•8 years ago
|
Iteration: --- → 53.1 - Nov 28
|
||
Updated•8 years ago
|
status-firefox52:
affected → ---
You need to log in
before you can comment on or make changes to this bug.
Description
•