1313834 - Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js

Status: RESOLVED FIXED

(Firefox :: Security, defect, P5)

Description

[Johann Hofmann [:johannh]]

SpecialPowers.pushPrefEnv returns a Promise, so we can remove the "new Promise(r =>" part of these lines:

http://searchfox.org/mozilla-central/search?q=Promise.*SpecialPowers&regexp=true&path=browser_aboutCertError.js

Comment 1

[catdesk]

I'll work on working on this.

Comment 2

[catdesk]

Attachment: Bug 1313834 - Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js.

Review commit: https://reviewboard.mozilla.org/r/89440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89440/

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8805756 [details]
Bug 1313834 - Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js.

https://reviewboard.mozilla.org/r/89440/#review88676

Nice, thank you! I'll do a push to try for you now (https://wiki.mozilla.org/ReleaseEngineering/TryServer) to test that everything is still working correctly.

Comment 4

[Johann Hofmann [:johannh]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f58ae14ec899

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f547d674f0c2
Clean up Promise usage of SpecialPowers.pushPrefEnv in browser_aboutCertError.js. r=johannh

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f547d674f0c2