Middle click on closed tab entry in history panel does nothing

VERIFIED FIXED in Firefox 52

Status

()

Firefox
Untriaged
VERIFIED FIXED
7 months ago
3 months ago

People

(Reporter: 6lobe, Assigned: David Malaschonok)

Tracking

({regression})

52 Branch
Firefox 52
regression
Points:
---

Firefox Tracking Flags

(firefox49 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52+ verified, firefox-esr45 unaffected)

Details

(Whiteboard: nightly-community)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

7 months ago
User Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20161029062601

Steps to reproduce:

Open hamburger menu. Open the History panel. Middle click on an entry.


Actual results:

The menu closes, but the entry does not open.


Expected results:

The clicked entry should have opened in a new tab.
(Reporter)

Updated

7 months ago
Has STR: --- → yes
OS: Unspecified → Linux
Hardware: Unspecified → x86
Whiteboard: nightly-community

Comment 1

7 months ago
[Tracking Requested - why for this release]: Regression of UI mouse response
Status: UNCONFIRMED → NEW
status-firefox49: --- → unaffected
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → affected
status-firefox-esr45: --- → unaffected
tracking-firefox52: --- → ?
Ever confirmed: true
Keywords: regression
OS: Linux → All
Hardware: x86 → All
Summary: Middle click on entry in history panel does nothing → Middle click on closed tab entry in history panel does nothing
(Reporter)

Comment 2

7 months ago
Here is the regression range:

24:36.01 INFO: Last good revision: a9a143d2179a352652b970b99d062214d1bf9bd8
24:36.01 INFO: First bad revision: da1b726ffaeec5de3211e9f38bfd38157cbf5bae
24:36.01 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a9a143d2179a352652b970b99d062214d1bf9bd8&tochange=da1b726ffaeec5de3211e9f38bfd38157cbf5bae

24:37.04 INFO: Looks like the following bug has the changes which introduced the regression:
https://bugzilla.mozilla.org/show_bug.cgi?id=926579
Blocks: 926579
Has Regression Range: --- → yes

Updated

7 months ago
Flags: needinfo?(davidmalaschonok)
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Flags: needinfo?(davidmalaschonok)
Assignee: nobody → davidmalaschonok
Status: NEW → ASSIGNED
Comment on attachment 8805833 [details]
Bug 1313876 - Fixed _undoCloseMiddleClick function call in event listener.

https://reviewboard.mozilla.org/r/89462/#review88958

Thanks for the quick fix.

It would be good to have a test cover this case since we missed it when we made the previuos refactoring. You could update the test at /browser/components/customizableui/test/browser_947914_button_history.js.

In the test, you can open and close a new tab with
  yield BrowserTestUtils.withNewTab("about:home", function*() {return true;});

Then when the menu is open, you can click on the menuitem using (something like) the following code,
  let recentlyClosedTab = document.querySelector("#PanelUI-recentlyClosedTabs > toolbarbutton:nth-child(2)");
  ok(recentlyClosedTab, "Got menuitem for recently closed tab");
  let reopenedAboutHomeTab = BrowserTestUtils.waitForNewTab(gBrowser, "about:home");
  EventUtils.synthesizeMouse(recentlyClosedTab, 2, 2, {button: 1});
  yield reopenedAboutHomeTab;
  ok(reopenedAboutHomeTab, "about:home tab reopened with middle click");
  yield BrowserTestUtils.removeTab(reopenedAboutHomeTab, {});

I'm getting an error with the call to synthesizeMouse there so this isn't perfect but hopefully it will get you on the right track.
Attachment #8805833 - Flags: review?(jaws) → review-
Comment on attachment 8805833 [details]
Bug 1313876 - Fixed _undoCloseMiddleClick function call in event listener.

https://reviewboard.mozilla.org/r/89462/#review89042

Upon further thought, let's land this now and we can land the test changes in a follow-up patch since I don't want this regression to linger.
Attachment #8805833 - Flags: review- → review+

Comment 6

7 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2cd8ae6771b2
Fixed _undoCloseMiddleClick function call in event listener. r=jaws
Tracking 52+ for this UI regression.
tracking-firefox52: ? → +

Comment 8

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2cd8ae6771b2
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Comment 9

4 months ago
I have reproduced this bug with Firefox nightly 52.0a1 (build id:20161029062601)on
windows 7(64 bit)

I have verified this bug as fixed with Firefox aurora 52.0a2(build id:20170119004006)
User agent:Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0

[testday-20170120]

Comment 10

4 months ago
I have reproduced this bug with Nightly 52.0a1 (2016-10-29) (64-bit) (Build ID 20161029062601) on ubuntu 16.10 , 64 Bit !

This bug's fix is verified with latest Developer Edition (Aurora)

Build   ID  20170119004006
User Agent  Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

[testday-20170120]
I've also verified this on 52.0b8-build1 (20170220070057) on Windows 10 x64, Mac OS X 10.12.3 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox52: fixed → verified
You need to log in before you can comment on or make changes to this bug.