131390 - Unitialized variables in js/src/xpconnect/src

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Heikki Toivonen (remove -bugzilla when emailing directly)]

I decided to take a look at these, and found one that actually is real. The
others seem to be just the compiler's inability to realize that they will never
be used uninitialized.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Proposed fix

This is real if we jump through goto to done before initializing:

js/src/xpconnect/src/xpcwrappednative.cpp:1627
`uint8 paramCount' might be used uninitialized in this function

1625 const nsXPTMethodInfo* methodInfo;
1626 uint8 requiredArgs;
1627 uint8 paramCount;
1628 jsval src;
1629 nsresult invokeResult;

I fixed the other ones so that it will be easier to notice new errors.

Comment 2

[Johnny Stenback (:jst)]

Mass-reassigning bugs to [e-mail]

Comment 3

[Fabian Guisset]

This patch to remove warnings of unitialized variables still seems to be
relevant. Do we want to take it?

Comment 4

[Nicholas Nethercote [inactive]]

All variables named |paramCount| in js/xpconnect/src/XPCWrappedNative.cpp (as it's now called) are initialized at declaration time.