1313950 - properly localize plurals of number of matches in Addressbook search

Status: RESOLVED FIXED

(MailNews Core :: Address Book, defect)

Description

[:aceman]

https://dxr.mozilla.org/comm-central/rev/6b8c7cd17855f7de5eccb0ea9efcd5dbccc68573/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#111 hardcodes 2 plural forms of the string "X matches found". This is fine for English but not other languages.

Fix this by using the usual PluralForm.jsm.

Comment 1

[:aceman]

Attachment: patch

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8805867 [details] [diff] [review]
patch

Review of attachment 8805867 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

::: mail/base/content/ABSearchDialog.js
@@ +31,5 @@
>      UpdateCardView();
>    },
> +  onCountChanged: function(aTotal) {
> +    let statusText;
> +    if (aTotal == 0)

nit: braces for this too

Comment 3

[:aceman]

Attachment: patch v1.1

Thanks.

Comment 4

[Ian Neal]

Comment on attachment 8807667 [details] [diff] [review]
patch v1.1

LGTM r/a=me

Comment 5

[:aceman]

Thanks.

Comment 6

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/b8ec04edc0e3e7248d01607653cb0bffb132aa6f

Comment 7

[Piotr Drąg [:piotrdrag]]

Dashboard shows an error for this string, even though it has been translated correctly:

https://l10n.mozilla.org/dashboard/compare?run=650844

https://hg.mozilla.org/l10n-central/pl/rev/0cf430ee6773

Comment 8

[:aceman]

Is this problem still happening? Is a newer run of the tool showing it?

Comment 9

[Piotr Drąg [:piotrdrag]]

Yes, it is: https://l10n.mozilla.org/dashboard/compare?run=652294

Comment 10

[:aceman]

Please make a new bug for this and we can try some experiments.

Comment 11

[Piotr Drąg [:piotrdrag]]

New bug is #1320570

Comment 12

[Jorg K (CEST = GMT+2)]

Comment on attachment 8807667 [details] [diff] [review]
patch v1.1

I will uplift this since otherwise bug 1319409 doesn't apply and I don't feel like messing around with a special patch here.

Comment 13

[Jorg K (CEST = GMT+2)]

Comment on attachment 8807667 [details] [diff] [review]
patch v1.1

Aurora (TB 52):
https://hg.mozilla.org/releases/comm-aurora/rev/5082b3870a86205345bb8a2d23456602dad7e7b7