Closed Bug 1313950 Opened 5 years ago Closed 5 years ago

properly localize plurals of number of matches in Addressbook search

Categories

(MailNews Core :: Address Book, defect)

Product:
MailNews Core
Component:
Address Book
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

(thunderbird52 fixed, thunderbird53 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 53.0
Tracking Flags:
Tracking Status
thunderbird52 --- fixed
thunderbird53 --- fixed

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(1 file, 1 obsolete file)

patch v1.1
11.16 KB, patch
iann_bugzilla
: review+
jorgk-bmo
: approval-comm-aurora+
Details | Diff | Splinter Review 
https://dxr.mozilla.org/comm-central/rev/6b8c7cd17855f7de5eccb0ea9efcd5dbccc68573/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#111 hardcodes 2 plural forms of the string "X matches found". This is fine for English but not other languages.

Fix this by using the usual PluralForm.jsm.
Attached patch patch (obsolete) — — Splinter Review
Attachment #8805867 - Flags: review?(mkmelin+mozilla)
Attachment #8805867 - Flags: review?(iann_bugzilla)
Comment on attachment 8805867 [details] [diff] [review]
patch

Review of attachment 8805867 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

::: mail/base/content/ABSearchDialog.js
@@ +31,5 @@
>      UpdateCardView();
>    },
> +  onCountChanged: function(aTotal) {
> +    let statusText;
> +    if (aTotal == 0)

nit: braces for this too
Attachment #8805867 - Flags: review?(mkmelin+mozilla) → review+
Attached patch patch v1.1 — — Splinter Review 
Thanks.
Attachment #8805867 - Attachment is obsolete: true
Attachment #8805867 - Flags: review?(iann_bugzilla)
Attachment #8807667 - Flags: review?(iann_bugzilla)
Comment on attachment 8807667 [details] [diff] [review]
patch v1.1

LGTM r/a=me
Attachment #8807667 - Flags: review?(iann_bugzilla) → review+
Thanks.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/b8ec04edc0e3e7248d01607653cb0bffb132aa6f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
Dashboard shows an error for this string, even though it has been translated correctly:

https://l10n.mozilla.org/dashboard/compare?run=650844

https://hg.mozilla.org/l10n-central/pl/rev/0cf430ee6773
Is this problem still happening? Is a newer run of the tool showing it?
Please make a new bug for this and we can try some experiments.
New bug is #1320570
Depends on: 1320570
Comment on attachment 8807667 [details] [diff] [review]
patch v1.1

I will uplift this since otherwise bug 1319409 doesn't apply and I don't feel like messing around with a special patch here.
Attachment #8807667 - Flags: approval-comm-aurora?
You need to log in before you can comment on or make changes to this bug.