Closed
Bug 1313950
Opened 9 years ago
Closed 9 years ago
properly localize plurals of number of matches in Addressbook search
Categories
(MailNews Core :: Address Book, defect)
MailNews Core
Address Book
Tracking
(thunderbird52 fixed, thunderbird53 fixed)
RESOLVED
FIXED
Thunderbird 53.0
People
(Reporter: aceman, Assigned: aceman)
References
Details
Attachments
(1 file, 1 obsolete file)
11.16 KB,
patch
|
iannbugzilla
:
review+
jorgk-bmo
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
https://dxr.mozilla.org/comm-central/rev/6b8c7cd17855f7de5eccb0ea9efcd5dbccc68573/mail/locales/en-US/chrome/messenger/addressbook/addressBook.properties#111 hardcodes 2 plural forms of the string "X matches found". This is fine for English but not other languages.
Fix this by using the usual PluralForm.jsm.
Attachment #8805867 -
Flags: review?(mkmelin+mozilla)
Attachment #8805867 -
Flags: review?(iann_bugzilla)
Comment 2•9 years ago
|
||
Comment on attachment 8805867 [details] [diff] [review]
patch
Review of attachment 8805867 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, r=mkmelin
::: mail/base/content/ABSearchDialog.js
@@ +31,5 @@
> UpdateCardView();
> },
> + onCountChanged: function(aTotal) {
> + let statusText;
> + if (aTotal == 0)
nit: braces for this too
Attachment #8805867 -
Flags: review?(mkmelin+mozilla) → review+
Thanks.
Attachment #8805867 -
Attachment is obsolete: true
Attachment #8805867 -
Flags: review?(iann_bugzilla)
Attachment #8807667 -
Flags: review?(iann_bugzilla)
Comment on attachment 8807667 [details] [diff] [review]
patch v1.1
LGTM r/a=me
Attachment #8807667 -
Flags: review?(iann_bugzilla) → review+
Comment 6•9 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
Comment 7•9 years ago
|
||
Dashboard shows an error for this string, even though it has been translated correctly:
https://l10n.mozilla.org/dashboard/compare?run=650844
https://hg.mozilla.org/l10n-central/pl/rev/0cf430ee6773
Is this problem still happening? Is a newer run of the tool showing it?
Comment 9•9 years ago
|
||
![]() |
Assignee | |
Comment 10•9 years ago
|
||
Please make a new bug for this and we can try some experiments.
Comment 11•9 years ago
|
||
New bug is #1320570
Comment 12•9 years ago
|
||
Comment on attachment 8807667 [details] [diff] [review]
patch v1.1
I will uplift this since otherwise bug 1319409 doesn't apply and I don't feel like messing around with a special patch here.
Attachment #8807667 -
Flags: approval-comm-aurora?
Comment 13•9 years ago
|
||
Comment on attachment 8807667 [details] [diff] [review]
patch v1.1
Aurora (TB 52):
https://hg.mozilla.org/releases/comm-aurora/rev/5082b3870a86205345bb8a2d23456602dad7e7b7
Attachment #8807667 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Updated•9 years ago
|
status-thunderbird52:
--- → fixed
status-thunderbird53:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•