1314016 - Crash in mozilla::dom::TabParent::RecvPDocAccessibleConstructor

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marcia Knous [:marcia]]

This bug was filed from the Socorro interface and is 
report bp-7a9f78d4-9e77-42f2-ad14-42cf32161031.
=============================================================

New crash that has risen to the top of trunk crashes - started with 20161029062601: http://bit.ly/2dUPwSr.

Maybe a manifestation of another bug, not sure. ni on Aaron since the top stack touches code worked on in Bug 1309236.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

This is RecvMsaaID reincarnate.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Patch

Since AddChildDoc can fail (in which case there is no wrapper), we need to check that before calling WrapperFor and SetID.

Comment 3

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8806514 [details] [diff] [review]
Patch

if it fails the tab will crash, but that's better than the main process crashing.  I suspect the real problem here is the same as all the other PDocAccessibleConstructor stuff, and I may have something that finally really works for that.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb1336d8898f8b84de79b5a9e152ce82ed4fb3df
Bug 1314016: Do not attempt to obtain wrapper and set MSAA ID on child document unless it was successfully added; r=tbsaunde

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/eb1336d8898f

Comment 6

[[:philipp]]

hi, this signature is also crashing on 51.0b & the patch looks fairly simple. would the fix be upliftable in terms of scope/risk?

Comment 7

[(No longer employed by Mozilla) Aaron Klotz]

Comment on attachment 8806514 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 1309236
[User impact if declined]: Crashes, though only users who have force-enabled e10s should be seeing them.
[Describe test coverage new/current, TreeHerder]: On 52+, crash is gone.
[Risks and why]: None, just a null pointer check
[String/UUID change made/needed]: None

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8806514 [details] [diff] [review]
Patch

Fix a crash. Beta51+. Should be in 51 beta 2.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/562fef9194ec