1314044 - Top Tabs for iPad toolbar is scrolled incorrectly after specific steps

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: 1bc8bb71f
Devices: 
- iPad Pro (9.2.1)
- iPad Air 2 (10.0.2) 

Steps to reproduce:
1. Open 12 tabs in Fennec (select the last tab)
2. Background by pressing the home button
3. Restore Fennec

Actual results:
- The scroll position is incorrect. The Top Tabs bar will be scrolled to the middle and the last tab which is selected will not be visible. 

Expected result: 
- Top Tabs toolbar should be scrolled to the selected tab.

Note:
- This issue is also reproducible in the following scenarios:
* When locking the device and restoring Fennec
* When switching to another app and after restoring Fennec
* When backgrounding Fennec using split screen feature and restoring
* When opening a new tab via Today Widget (No scroll to the selected tab)
* When opening tapping on 'Help' from the 'Settings' menu (Top tabs will not scroll to the Help tab)
* When changing device orientation to landscape

See the video for more information: 
https://www.youtube.com/watch?v=5P53WIbrhvE

Comment 1

[Farhan Patel [:farhan]]

Attachment: Pull Request

This is a pretty big change. I'd love some feedback :)

Comment 2

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/51c7e1dbd2ee4ee0463ebf5e9867454a69840412

Comment 3

[Simon Basca [:SimonB]]

Verifying as fix on latest master 51abcc7ca.