Top Tabs for iPad toolbar is scrolled incorrectly after specific steps

VERIFIED FIXED

Status

()

Firefox for iOS
General
P1
normal
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: SimonB, Assigned: farhan)

Tracking

(Blocks: 1 bug)

unspecified
All
iOS

Firefox Tracking Flags

(fxios-v6.0 unaffected, fxios7.0+)

Details

(Whiteboard: [mobileCore])

Attachments

(1 attachment)

55 bytes, text/x-github-pull-request
jhugman
: feedback+
Details | Review | Splinter Review
(Reporter)

Description

2 years ago
Build: 1bc8bb71f
Devices: 
- iPad Pro (9.2.1)
- iPad Air 2 (10.0.2) 

Steps to reproduce:
1. Open 12 tabs in Fennec (select the last tab)
2. Background by pressing the home button
3. Restore Fennec

Actual results:
- The scroll position is incorrect. The Top Tabs bar will be scrolled to the middle and the last tab which is selected will not be visible. 

Expected result: 
- Top Tabs toolbar should be scrolled to the selected tab.

Note:
- This issue is also reproducible in the following scenarios:
* When locking the device and restoring Fennec
* When switching to another app and after restoring Fennec
* When backgrounding Fennec using split screen feature and restoring
* When opening a new tab via Today Widget (No scroll to the selected tab)
* When opening tapping on 'Help' from the 'Settings' menu (Top tabs will not scroll to the Help tab)
* When changing device orientation to landscape

See the video for more information: 
https://www.youtube.com/watch?v=5P53WIbrhvE
status-fxios-v6.0: affected → unaffected
tracking-fxios: ? → 7.0+
Priority: -- → P3
(Assignee)

Updated

2 years ago
Blocks: 1305800
No longer blocks: 1278667
(Assignee)

Updated

2 years ago
Assignee: nobody → fpatel
Iteration: --- → 1.12
Priority: P3 → P1
(Assignee)

Updated

2 years ago
Whiteboard: [mobileCore]

Updated

2 years ago
Iteration: 1.12 → 1.13
(Assignee)

Comment 1

2 years ago
Created attachment 8828083 [details] [review]
Pull Request

This is a pretty big change. I'd love some feedback :)
Attachment #8828083 - Flags: review?(sleroux)
Attachment #8828083 - Flags: feedback?(jhugman)
Attachment #8828083 - Flags: feedback?(etoop)
Attachment #8828083 - Flags: feedback?(jhugman) → feedback+
(Assignee)

Comment 2

2 years ago
master https://github.com/mozilla-mobile/firefox-ios/commit/51c7e1dbd2ee4ee0463ebf5e9867454a69840412
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Attachment #8828083 - Flags: feedback?(etoop)
Attachment #8828083 - Flags: review?(sleroux)
(Reporter)

Comment 3

2 years ago
Verifying as fix on latest master 51abcc7ca.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.