Closed Bug 1314085 Opened 3 years ago Closed 3 years ago

Change cubeb MOZ_LOG error level

Categories

(Core :: Audio/Video: cubeb, defect, P2)

52 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: achronop, Assigned: achronop)

Details

Attachments

(1 file)

The CubebLogCallback used to wire MOZ_LOG with cubeb log system makes use of Verbose log level. Everything works fine when Verbose level is requested. Problem appears when requested level is less than that, the log system does not log anything because all cubeb logs inside gecko are Verbose logs. 

I solved it by setting all cubeb logs to Error (which is the lower level). It's not ideal though so if there is any better idea  please share.
Assignee: nobody → achronop
Rank: 25
OS: Unspecified → All
Priority: -- → P2
Hardware: Unspecified → All
Version: unspecified → 52 Branch
Attachment #8806032 - Flags: review?(padenot)
Comment on attachment 8806032 [details] [diff] [review]
Change cubeb log level to Error

Review of attachment 8806032 [details] [diff] [review]:
-----------------------------------------------------------------

It's good enough for now I think.
Attachment #8806032 - Flags: review?(padenot) → review+
https://hg.mozilla.org/mozilla-central/rev/7c1c7953fe42
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.