Closed Bug 1314194 Opened 3 years ago Closed 3 years ago

Make sure we don't recycle texture in the GPU process before they have finished being used.

Categories

(Core :: Graphics: Layers, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox52 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(1 file)

We currently have a race condition where we send DeallocateSurfaceDescriptorGPUVideo to the GPU process before the compositor has actually finished reading from the texture.

If we mark the TextureClient for GPUVideoTextureData as being 'recycle', then ImageBridgeChild will hold on to a ref to the GPUVideoTextureData until we've released the compositor side objects.

Even though we don't actually recycle these, that shouldn't matter, and it ensures we don't send the Deallocate message until it's truly safe to do so.
Attachment #8806197 - Flags: review?(nical.bugzilla)
Attachment #8806197 - Flags: review?(nical.bugzilla) → review+
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c40aca368c01
Make sure we don't recycle textures in the GPU process before they have finished being used. r=nical
https://hg.mozilla.org/mozilla-central/rev/c40aca368c01
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.