1314213 - hideNotNow doesn't work in PermissionUI.jsm

Status: RESOLVED FIXED

(Firefox :: Site Permissions, defect)

Description

[C.M.Chang[:chunmin]]

The 'dismiss' doesn't be propagated from |PermissionPromptPrototype.promptActions| to PopupNotifications Actions[0], so hideNotNow can not work. When hideNotNow = true, at least one of the actions needs to have the 'dismiss' property set to true[1].

[0] http://searchfox.org/mozilla-central/rev/021e8e0cee4f446757b8b1ffd312272174d6fc7b/browser/modules/PermissionUI.jsm#297
[1] http://searchfox.org/mozilla-central/rev/021e8e0cee4f446757b8b1ffd312272174d6fc7b/toolkit/modules/PopupNotifications.jsm#374

Comment 1

[C.M.Chang[:chunmin]]

Attachment: Pass dismiss

Comment 2

[C.M.Chang[:chunmin]]

Attachment: Bug 1314213 - Pass dismiss from PermissionPromptPrototype to PopupNotifications;

Review commit: https://reviewboard.mozilla.org/r/89718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89718/

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8806232 [details]
Bug 1314213 - Pass dismiss from PermissionPromptPrototype to PopupNotifications;

https://reviewboard.mozilla.org/r/89718/#review89354

I suppose this is fine - but keep an eye on bug 1282768, which is removing `hideNotNow`.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8806232 [details]
Bug 1314213 - Pass dismiss from PermissionPromptPrototype to PopupNotifications;

https://reviewboard.mozilla.org/r/89718/#review89354

Forgot to say this - thanks for the patch! :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/19605fd7b009
Pass dismiss from PermissionPromptPrototype to PopupNotifications; r=mconley

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/19605fd7b009