Closed Bug 1314213 Opened 3 years ago Closed 3 years ago

hideNotNow doesn't work in PermissionUI.jsm

Categories

(Firefox :: Site Permissions, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: chunmin, Assigned: chunmin)

References

Details

Attachments

(2 files)

The 'dismiss' doesn't be propagated from |PermissionPromptPrototype.promptActions| to PopupNotifications Actions[0], so hideNotNow can not work. When hideNotNow = true, at least one of the actions needs to have the 'dismiss' property set to true[1].

[0] http://searchfox.org/mozilla-central/rev/021e8e0cee4f446757b8b1ffd312272174d6fc7b/browser/modules/PermissionUI.jsm#297
[1] http://searchfox.org/mozilla-central/rev/021e8e0cee4f446757b8b1ffd312272174d6fc7b/toolkit/modules/PopupNotifications.jsm#374
Attached patch Pass dismissSplinter Review
Assignee: nobody → cchang
Status: NEW → ASSIGNED
Blocks: 1289974
Comment on attachment 8806232 [details]
Bug 1314213 - Pass dismiss from PermissionPromptPrototype to PopupNotifications;

https://reviewboard.mozilla.org/r/89718/#review89354

I suppose this is fine - but keep an eye on bug 1282768, which is removing `hideNotNow`.
Attachment #8806232 - Flags: review?(mconley) → review+
Comment on attachment 8806232 [details]
Bug 1314213 - Pass dismiss from PermissionPromptPrototype to PopupNotifications;

https://reviewboard.mozilla.org/r/89718/#review89354

Forgot to say this - thanks for the patch! :)
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19605fd7b009
Pass dismiss from PermissionPromptPrototype to PopupNotifications; r=mconley
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/19605fd7b009
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.