Closed Bug 1314214 Opened 3 years ago Closed 3 years ago

Remove User Agent override for Yahoo! Japan

Categories

(Web Compatibility :: Tooling & Investigations, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: karlcow, Assigned: miketaylr)

References

Details

Attachments

(1 file)

Yahoo! Japan is sending Firefox Android the mobile version of the Web site.

Request:

```http
GET / HTTP/1.1
Host: www.yahoo.co.jp
User-Agent: Mozilla/5.0 (Android 5.1.1; Mobile; rv:51.0) Gecko/51.0 Firefox/51.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
Cookie: B=b6akt9tc1g9kc&b=3&s=mu
Connection: keep-alive
Upgrade-Insecure-Requests: 1
```


Response:

```http
HTTP/1.1 302 Moved Temporarily
Server: nginx
Date: Tue, 01 Nov 2016 05:55:05 GMT
Content-Type: text/html; charset=UTF-8
Content-Length: 0
Connection: close
P3P: policyref="http://privacy.yahoo.co.jp/w3c/p3p_jp.xml", CP="CAO DSP COR CUR ADM DEV TAI PSA PSD IVAi IVDi CONi TELo OTPi OUR DELi SAMi OTRi UNRi PUBi IND PHY ONL UNI PUR FIN COM NAV INT DEM CNT STA POL HEA PRE GOV"
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
Location: http://m.yahoo.co.jp/
Expires: -1
Pragma: no-cache
Cache-Control: private, no-cache, no-store, must-revalidate
X-XRDS-Location: https://open.login.yahooapis.jp/openid20/www.yahoo.co.jp/xrds
X-Frame-Options: SAMEORIGIN, SAMEORIGIN
```


\o/

Let's modify

Aka remove line 6 to 9
https://dxr.mozilla.org/mozilla-central/rev/37ab1d54a08e7e1431660b22377428b74dcd090a/mobile/android/app/ua-update.json.in#6-9


Depends on 1177298
Depends on: 1177298
Oh wait it's getting better.


Request for finance.yahoo.co.jp

```http
GET / HTTP/1.1
Host: finance.yahoo.co.jp
User-Agent: Mozilla/5.0 (Android 5.1.1; Mobile; rv:51.0) Gecko/51.0 Firefox/51.0
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-US,en;q=0.5
Accept-Encoding: gzip, deflate
Cookie: B=b6akt9tc1g9kc&b=3&s=mu; YJMT=4xtREDjxiGwwOhI5rBMq9XvRPHRWYKs.; prn=promo_issued=1477979713762&promo_issued_type=click
Connection: keep-alive
Upgrade-Insecure-Requests: 1
```

Response

```http
HTTP/1.1 302 Found
Date: Tue, 01 Nov 2016 06:09:39 GMT
P3P: policyref="http://privacy.yahoo.co.jp/w3c/p3p_jp.xml", CP="CAO DSP COR CUR ADM DEV TAI PSA PSD IVAi IVDi CONi TELo OTPi OUR DELi SAMi OTRi UNRi PUBi IND PHY ONL UNI PUR FIN COM NAV INT DEM CNT STA POL HEA PRE GOV"
X-Content-Type-Options: nosniff
X-XSS-Protection: 1; mode=block
X-Frame-Options: SAMEORIGIN
Location: http://m.finance.yahoo.co.jp/
Cache-Control: private
Content-Length: 3182
Content-Type: text/html
Age: 0
Connection: keep-alive
Server: ATS
```


So we can remove line 10 too.
https://dxr.mozilla.org/mozilla-central/rev/37ab1d54a08e7e1431660b22377428b74dcd090a/mobile/android/app/ua-update.json.in#10
Thanks for testing -- I'll take this.
Assignee: nobody → miket
Comment on attachment 8806351 [details] [diff] [review]
Remove Yahoo! Japan finance and homepage UA overrides. r?karlcow

Thanks Mike. Let's do it.
Attachment #8806351 - Flags: review?(kdubost) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2cae9cfcf54d
Remove Yahoo! Japan finance and homepage UA overrides. r=karlcow
Keywords: checkin-needed
Karl, no need to add checkin-needed keyword for me, I was planning on updating the commit message from r?karlcow to r=karlcow before pushing.

(But it looks like whoever did the check-in was kind enough to fix the commit message, so thanks to whoever did that)
https://hg.mozilla.org/mozilla-central/rev/2cae9cfcf54d
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.