1314237 - Nightly and Developer Edition are not detected as 'firefox' by the import/migration tool's default browser detection

Status: RESOLVED FIXED

(Firefox :: Migration, defect)

Description

[:Gijs (he/him)]

This put up unnecessary hurdles for verification in bug 1279240, so I'm just going to write the trivial patch to make this problem go away, even if it isn't/shouldn't be super high priority otherwise.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1314237 - detect nightly/devedition as 'firefox' in migration code,

Review commit: https://reviewboard.mozilla.org/r/89794/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89794/

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8806304 [details]
Bug 1314237 - detect nightly/devedition as 'firefox' in migration code,

https://reviewboard.mozilla.org/r/89794/#review89244

::: browser/components/migration/MigrationUtils.jsm:692
(Diff revision 1)
>        let browserDesc =
>          Cc["@mozilla.org/uriloader/external-protocol-service;1"]
>            .getService(Ci.nsIExternalProtocolService)
>            .getApplicationDescription("http");
>        key = APP_DESC_TO_KEY[browserDesc] || "";
> +      // Handle devedition, as well as "FirefoxNightly" on OS X

nit: missing dot.

(Just like you, I like this better than adding 'FirefoxNightly' and 'FirefoxDeveloperEdition' to the LUT above, because it's nicely future-proof.)

Comment 3

[:Gijs (he/him)]

Comment on attachment 8806304 [details]
Bug 1314237 - detect nightly/devedition as 'firefox' in migration code,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89794/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a5f7320aff0
detect nightly/devedition as 'firefox' in migration code, r=mikedeboer

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a5f7320aff0