Nightly and Developer Edition are not detected as 'firefox' by the import/migration tool's default browser detection

RESOLVED FIXED in Firefox 52

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Gijs, Assigned: Gijs)

Tracking

Trunk
Firefox 52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

3 years ago
This put up unnecessary hurdles for verification in bug 1279240, so I'm just going to write the trivial patch to make this problem go away, even if it isn't/shouldn't be super high priority otherwise.
Assignee

Updated

3 years ago
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

3 years ago
mozreview-review
Comment on attachment 8806304 [details]
Bug 1314237 - detect nightly/devedition as 'firefox' in migration code,

https://reviewboard.mozilla.org/r/89794/#review89244

::: browser/components/migration/MigrationUtils.jsm:692
(Diff revision 1)
>        let browserDesc =
>          Cc["@mozilla.org/uriloader/external-protocol-service;1"]
>            .getService(Ci.nsIExternalProtocolService)
>            .getApplicationDescription("http");
>        key = APP_DESC_TO_KEY[browserDesc] || "";
> +      // Handle devedition, as well as "FirefoxNightly" on OS X

nit: missing dot.

(Just like you, I like this better than adding 'FirefoxNightly' and 'FirefoxDeveloperEdition' to the LUT above, because it's nicely future-proof.)
Attachment #8806304 - Flags: review?(mdeboer) → review+
Comment hidden (mozreview-request)

Comment 4

3 years ago
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4a5f7320aff0
detect nightly/devedition as 'firefox' in migration code, r=mikedeboer

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4a5f7320aff0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.