Closed Bug 1314237 Opened 4 years ago Closed 4 years ago

Nightly and Developer Edition are not detected as 'firefox' by the import/migration tool's default browser detection

Categories

(Firefox :: Migration, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: Gijs, Assigned: Gijs)

Details

Attachments

(1 file)

This put up unnecessary hurdles for verification in bug 1279240, so I'm just going to write the trivial patch to make this problem go away, even if it isn't/shouldn't be super high priority otherwise.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Comment on attachment 8806304 [details]
Bug 1314237 - detect nightly/devedition as 'firefox' in migration code,

https://reviewboard.mozilla.org/r/89794/#review89244

::: browser/components/migration/MigrationUtils.jsm:692
(Diff revision 1)
>        let browserDesc =
>          Cc["@mozilla.org/uriloader/external-protocol-service;1"]
>            .getService(Ci.nsIExternalProtocolService)
>            .getApplicationDescription("http");
>        key = APP_DESC_TO_KEY[browserDesc] || "";
> +      // Handle devedition, as well as "FirefoxNightly" on OS X

nit: missing dot.

(Just like you, I like this better than adding 'FirefoxNightly' and 'FirefoxDeveloperEdition' to the LUT above, because it's nicely future-proof.)
Attachment #8806304 - Flags: review?(mdeboer) → review+
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/4a5f7320aff0
detect nightly/devedition as 'firefox' in migration code, r=mikedeboer
https://hg.mozilla.org/mozilla-central/rev/4a5f7320aff0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.