1314260 - Activity Stream default favicon color so dark that the image within is not visible

Status: VERIFIED FIXED

(Firefox for iOS :: Home screen, defect, P1)

Description

[Maurya Talisetti]

Attachment: Simulator Screen Shot 01-Nov-2016, 5.45.43 PM.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:49.0) Gecko/20100101 Firefox/49.0
Build ID: 20161019084923

Steps to reproduce:

Prerequisite: Requires a decent amount of history in your desktop Firefox to reproduce. This will ensure that a lot of tiles with no icons load into our iOS browser.

1. Launch Firefox for iOS
2. Clear Private Data (essential to ensure our activity stream is populated mainly with Desktop data)
3. Tap the Activity Stream Panel if not already open
4. Log into sync account and sync
5. Wait for Activity Stream to load top sites and highlights from your desktop


Actual results:

You'll notice that some tiles are very dark. So dark that the default favicon (usually the first alphabet of the domain) image is not properly visible. Especially, bright green, turquoise, bright blue. See screenshot.


Expected results:

The background colors for the default favicons shouldn't have such a dark tinge. And, more importantly the default favicon (alphabet) image should be visible.

Comment 1

[Bryan Munar (:bkmunar)]

Bryan Bell asked for this to be a white color a while ago - I'll fix this.

Comment 2

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 3

[Bryan Munar (:bkmunar)]

https://github.com/mozilla-mobile/firefox-ios/pull/2225/commits/f1adceb900dd4f30cb6589d048df7fbf963735e5

Comment 4

[Simon Basca [:SimonB]]

Verifying as fix on master 51abcc7c. 

The default favicon (alphabet) image is visible.