1314450 - this._updateAutoScrollEnabled is not a function error when tearing off

Status: RESOLVED FIXED

(Instantbird Graveyard :: Conversation, defect)

Description

[Florian Quèze [:florian]]

TypeError: this._updateAutoScrollEnabled is not a function
	autoScrollEnabled chrome://chat/content/convbrowser.xml:347:47
	bound autoScrollEnabled self-hosted
	handleLastMessage chrome://instantbird/content/instantbird.xul:124:9

If the conversation was the last tab of the window, the window fails to close.

The problem is the 2 bound functions at http://searchfox.org/comm-central/source/chat/content/convbrowser.xml#916

                this.contentWindow.scrollToElement = this._scrollToElement.bind(this);
                this.contentWindow.autoScrollEnabled = this.autoScrollEnabled.bind(this);

These should be updated when swapping the docshells.

Comment 1

[aleth [:aleth]]

Attachment: Update methods exposed to content when swapping docshells

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8806931 [details] [diff] [review]
Update methods exposed to content when swapping docshells

Review of attachment 8806931 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! The code change looks good, I assume you verified it has the intended effect.

Comment 3

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/dd56104d2a03835869611acc5837e5f74cfeb5fd
Bug 1314450 - Update methods exposed to content when swapping docshells. r=florian