1314493 - non-e10s WebRequest failure with stream.seek

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Description

[Shane Caraveo (:mixedpuppy)]

This issue was unmasked by bug 1273138, with which this would be a perma-orange on non-e10s.  xhr using a blob has a stream that apparently needs QI to rewind.  

The larger part of this is deconstructing part of the webrequest tests, pulling out the upload tests that were added in bug 1201979.  

Bug 1314492 will hopefully put future confusion to rest.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1314493 simplify xhr webrequest tests for uploads, fix xhr blob send,

Review commit: https://reviewboard.mozilla.org/r/89958/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/89958/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8806571 [details]
Bug 1314493 simplify xhr webrequest tests for uploads, fix xhr blob send,

https://reviewboard.mozilla.org/r/89958/#review89470

Much better. Thank you!

::: toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html:110
(Diff revision 1)
> +    } else if (name == "onCompleted") {
> +      browser.test.sendMessage("done");
> +    }
> +  }
> +
> +  for (let name in events) {

Nit: `for (let [name, args] of Object.entries(events))`

::: toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html:136
(Diff revision 1)
> +        "webRequest",
> +        "webRequestBlocking",
> +        "<all_urls>",
> +      ],
> +    },
> +    background: `(${background})()`,

Nit: No need for the stringification anymore, just: `background,`

::: toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html:174
(Diff revision 1)
> +        let xhr = new XMLHttpRequest();
> +        action.searchParams.set("xhr", "1");
> +        xhr.open("POST", action.href);
> +        xhr.send(data);
> +        action.searchParams.delete("xhr");
> +        extension.awaitMessage("done").then(resolve);

Nit: No need for the `new Promise`. Just send the XUR and then return `extension.awaitMessage(...)`

::: toolkit/components/extensions/test/mochitest/test_ext_webrequest_upload.html:196
(Diff revision 1)
> +
> +

Nit: extra lines

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8806571 [details]
Bug 1314493 simplify xhr webrequest tests for uploads, fix xhr blob send,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/89958/diff/1-2/

Comment 4

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7d82d1000473

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/60266cddf76a
simplify xhr webrequest tests for uploads, fix xhr blob send, r=kmag

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/60266cddf76a

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8806571 [details]
Bug 1314493 simplify xhr webrequest tests for uploads, fix xhr blob send,

Approval Request Comment
[Feature/regressing bug #]: Bug 1303798
[User impact if declined]: This patch blocks the uplift request for Bug 1303798
[Describe test coverage new/current, TreeHerder]: This is primarily test changes
[Risks and why]: Very low, primarily test change, only adds a QI to fix a non-e10s failure case
[String/UUID change made/needed]: none

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8806571 [details]
Bug 1314493 simplify xhr webrequest tests for uploads, fix xhr blob send,

Fix an issue related to non-e10s WebRequest failure. Take it in 51 aurora.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/038cb3a7fd57