1314528 - [webconsole] enable mocha tests on windows

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[[e-mail]]

current setup has some limitation that prevent enzyme test on windows

The main issue is the NODE_PATH can not be set correctly on windows

Comment 1

[[e-mail]]

Attachment: Bug 1314528 - [webconsole] rename requireHelper to require-helper;

Review commit: https://reviewboard.mozilla.org/r/90008/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90008/

Comment 2

[Lin Clark [:linclark]]

Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

https://reviewboard.mozilla.org/r/90008/#review89624

Good idea!

Just one minor problem. It looks like the require-helper.js file wasn't moved, but instead was deleted and recreated. Can you make sure that you used hg/git mv?

Comment 3

[[e-mail]]

Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90008/diff/1-2/

Comment 4

[Lin Clark [:linclark]]

Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

https://reviewboard.mozilla.org/r/90008/#review90340

I'm confused by this review request. It looks like the change I requested (using git/hg mv) wasn't made. When I look at the patch, it says it's using new file mode. Unless I'm mistaken, it should not display this in the patch.

Are you using git for development? If so, you may need to change the way you create patches. I use the following alias in my git config:

[alias]
        hgp = "show --binary --find-renames --format=\"# HG changeset patch%n# User %an <%ae>%n%B\" -U8"

Comment 5

[[e-mail]]

My apologize that I just checked local git/cinnabar status and make sure it shows `rename` instead of `create/delete` for different file. 

Since its not an urgent issue, I'll try add alias as you suggest after back to the office(a week later).

Comment 6

[[e-mail]]

Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90008/diff/2-3/

Comment 7

[[e-mail]]

I add the alias and found it does not work because I also did some change on require-helper.js

1. to add react-dom, react-redux support
2. change the react-dev to the relative path, therefore we only need single NODE_PATH reference on `npm test`

That makes git treat it as an add but not a rename.

Comment 8

[Lin Clark [:linclark]]

Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

https://reviewboard.mozilla.org/r/90008/#review93112

If you do the move as a separate commit and then make the change, it should work.

Comment 9

[[e-mail]]

Attachment: Bug 1314528 - [webconsole] enable mocha test on windows;

Review commit: https://reviewboard.mozilla.org/r/93310/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93310/

Comment 10

[[e-mail]]

Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/90008/diff/3-4/

Comment 11

[[e-mail]]

Do separate commit and it works, thanks!

Comment 12

[Lin Clark [:linclark]]

Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

https://reviewboard.mozilla.org/r/90008/#review94522

Comment 13

[Lin Clark [:linclark]]

Comment on attachment 8811096 [details]
Bug 1314528 - [webconsole] enable mocha test on windows;

https://reviewboard.mozilla.org/r/93310/#review94524

Comment 14

[[e-mail]]

thanks!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f045bf57e5a4
[webconsole] rename requireHelper to require-helper;r=linclark
https://hg.mozilla.org/integration/autoland/rev/099d20dd6745
[webconsole] enable mocha test on windows;r=linclark

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f045bf57e5a4
https://hg.mozilla.org/mozilla-central/rev/099d20dd6745