Closed Bug 1314528 Opened 3 years ago Closed 3 years ago

[webconsole] enable mocha tests on windows

Categories

(DevTools :: Console, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

Attachments

(2 files)

current setup has some limitation that prevent enzyme test on windows

The main issue is the NODE_PATH can not be set correctly on windows
Assignee: nobody → gasolin
Status: NEW → ASSIGNED
Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

https://reviewboard.mozilla.org/r/90008/#review89624

Good idea!

Just one minor problem. It looks like the require-helper.js file wasn't moved, but instead was deleted and recreated. Can you make sure that you used hg/git mv?
Attachment #8806603 - Flags: review?(lclark) → review-
Summary: [webconsole] enable enzyme test on windows → [webconsole] enable mocha tests on windows
Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

https://reviewboard.mozilla.org/r/90008/#review90340

I'm confused by this review request. It looks like the change I requested (using git/hg mv) wasn't made. When I look at the patch, it says it's using new file mode. Unless I'm mistaken, it should not display this in the patch.

Are you using git for development? If so, you may need to change the way you create patches. I use the following alias in my git config:

[alias]
        hgp = "show --binary --find-renames --format=\"# HG changeset patch%n# User %an <%ae>%n%B\" -U8"
Attachment #8806603 - Flags: review?(lclark) → review-
My apologize that I just checked local git/cinnabar status and make sure it shows `rename` instead of `create/delete` for different file. 

Since its not an urgent issue, I'll try add alias as you suggest after back to the office(a week later).
I add the alias and found it does not work because I also did some change on require-helper.js

1. to add react-dom, react-redux support
2. change the react-dev to the relative path, therefore we only need single NODE_PATH reference on `npm test`

That makes git treat it as an add but not a rename.
Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

https://reviewboard.mozilla.org/r/90008/#review93112

If you do the move as a separate commit and then make the change, it should work.
Attachment #8806603 - Flags: review?(lclark) → review-
Do separate commit and it works, thanks!
Comment on attachment 8806603 [details]
Bug 1314528 - [webconsole] rename requireHelper to require-helper;

https://reviewboard.mozilla.org/r/90008/#review94522
Attachment #8806603 - Flags: review?(lclark) → review+
Comment on attachment 8811096 [details]
Bug 1314528 - [webconsole] enable mocha test on windows;

https://reviewboard.mozilla.org/r/93310/#review94524
Attachment #8811096 - Flags: review?(lclark) → review+
thanks!
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f045bf57e5a4
[webconsole] rename requireHelper to require-helper;r=linclark
https://hg.mozilla.org/integration/autoland/rev/099d20dd6745
[webconsole] enable mocha test on windows;r=linclark
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f045bf57e5a4
https://hg.mozilla.org/mozilla-central/rev/099d20dd6745
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.