1314535 - MDSM::mediaSeekable should be updated by the reader instead of MediaDecoder

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

MDSM should listen to MediaDecoderReader::OnMediaNotSeekable() without going through MediaDecoder.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1314535. Part 1 - listen to MediaDecoderReader::OnMediaNotSeekable() to update mMediaSeekable.

Review commit: https://reviewboard.mozilla.org/r/90282/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90282/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1314535. Part 2 - remove unused canonical.

Review commit: https://reviewboard.mozilla.org/r/90284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90284/

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8807016 [details]
Bug 1314535. Part 1 - listen to MediaDecoderReader::OnMediaNotSeekable() to update mMediaSeekable.

https://reviewboard.mozilla.org/r/90282/#review90570

::: dom/media/MediaDecoderStateMachine.cpp:2188
(Diff revision 1)
>    mVideoQueueListener = VideoQueue().PopEvent().Connect(
>      mTaskQueue, this, &MediaDecoderStateMachine::OnVideoPopped);
>  
>    mMetadataManager.Connect(mReader->TimedMetadataEvent(), OwnerThread());
>  
> +  mOnMediaNotSeekable = mReader->OnMediaNotSeekable().Connect(

It feels weird to have the initialization done in one class while the disconnection occurs in another...

Comment 4

[Jean-Yves Avenard [:jya]]

Comment on attachment 8807017 [details]
Bug 1314535. Part 2 - remove unused canonical.

https://reviewboard.mozilla.org/r/90284/#review90572

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8807016 [details]
Bug 1314535. Part 1 - listen to MediaDecoderReader::OnMediaNotSeekable() to update mMediaSeekable.

https://reviewboard.mozilla.org/r/90282/#review90570

> It feels weird to have the initialization done in one class while the disconnection occurs in another...

MDSM serves as a context object for the underlying state objects. There are some variables shared across the state objects which are written in one state and read in another.

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1116434cbf0
Part 1 - listen to MediaDecoderReader::OnMediaNotSeekable() to update mMediaSeekable. r=jya
https://hg.mozilla.org/integration/autoland/rev/38bae57379ad
Part 2 - remove unused canonical. r=jya

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f1116434cbf0
https://hg.mozilla.org/mozilla-central/rev/38bae57379ad