MDSM::mediaSeekable should be updated by the reader instead of MediaDecoder

RESOLVED FIXED in Firefox 52

Status

()

defect
P3
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jwwang, Assigned: jwwang)

Tracking

unspecified
mozilla52
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

3 years ago
MDSM should listen to MediaDecoderReader::OnMediaNotSeekable() without going through MediaDecoder.
Assignee

Updated

3 years ago
Assignee: nobody → jwwang
Blocks: 1286129
Priority: -- → P3
Comment hidden (mozreview-request)
Assignee

Updated

3 years ago
Attachment #8807016 - Flags: review?(jyavenard)
Attachment #8807017 - Flags: review?(jyavenard)

Comment 3

3 years ago
mozreview-review
Comment on attachment 8807016 [details]
Bug 1314535. Part 1 - listen to MediaDecoderReader::OnMediaNotSeekable() to update mMediaSeekable.

https://reviewboard.mozilla.org/r/90282/#review90570

::: dom/media/MediaDecoderStateMachine.cpp:2188
(Diff revision 1)
>    mVideoQueueListener = VideoQueue().PopEvent().Connect(
>      mTaskQueue, this, &MediaDecoderStateMachine::OnVideoPopped);
>  
>    mMetadataManager.Connect(mReader->TimedMetadataEvent(), OwnerThread());
>  
> +  mOnMediaNotSeekable = mReader->OnMediaNotSeekable().Connect(

It feels weird to have the initialization done in one class while the disconnection occurs in another...
Attachment #8807016 - Flags: review?(jyavenard) → review+

Comment 4

3 years ago
mozreview-review
Comment on attachment 8807017 [details]
Bug 1314535. Part 2 - remove unused canonical.

https://reviewboard.mozilla.org/r/90284/#review90572
Attachment #8807017 - Flags: review?(jyavenard) → review+
Assignee

Comment 5

3 years ago
mozreview-review-reply
Comment on attachment 8807016 [details]
Bug 1314535. Part 1 - listen to MediaDecoderReader::OnMediaNotSeekable() to update mMediaSeekable.

https://reviewboard.mozilla.org/r/90282/#review90570

> It feels weird to have the initialization done in one class while the disconnection occurs in another...

MDSM serves as a context object for the underlying state objects. There are some variables shared across the state objects which are written in one state and read in another.
Assignee

Comment 6

3 years ago
Thanks for the review!

Comment 7

3 years ago
Pushed by jwwang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f1116434cbf0
Part 1 - listen to MediaDecoderReader::OnMediaNotSeekable() to update mMediaSeekable. r=jya
https://hg.mozilla.org/integration/autoland/rev/38bae57379ad
Part 2 - remove unused canonical. r=jya

Comment 8

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f1116434cbf0
https://hg.mozilla.org/mozilla-central/rev/38bae57379ad
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.