1314556 - Convert TestAudioEventTimeline.cpp to a gtest

Status: RESOLVED FIXED

(Core :: Web Audio, defect, P2)

Description

[Nicholas Nethercote [inactive]]

This removes another GeckoCppUnitTest, which helps with bug 1313141.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Convert TestAudioEventTimeline.cpp to a gtest

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 8806651 [details] [diff] [review]
Convert TestAudioEventTimeline.cpp to a gtest

Review of attachment 8806651 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the comments addressed.

Thanks for doing that Nicholas. Should we transition our other compiled tests to gTests, are they not causing issues?

::: dom/media/webaudio/gtest/TestAudioEventTimeline.cpp
@@ +48,5 @@
>  template <class T, class U>
>  void is(const T& a, const U& b, const char* msg)
>  {
>    std::stringstream ss;
> +  ss << msg << ", Got: " << a << ", expected: " << b << '\n';

`std::endl` instead of `\n` please.

@@ +59,5 @@
>    // stupidly high, since we mostly care about the correctness of the algorithm
>    const float kEpsilon = 0.00001f;
>  
>    std::stringstream ss;
> +  ss << msg << ", Got: " << a << ", expected: " << b << 'n';

`std::endl` instead of just the letter 'n' please :-).

Comment 3

[Nicholas Nethercote [inactive]]

> Should we transition our other compiled tests to gTests, are they not causing issues?

I'm not sure exactly which tests you are referring to, but the ones in dom/media/compiledtest/ will need conversion too. I'll look at them soon. And see attachment 8806764 [details] for the full list of tests blocking bug 1313141.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce032e762e19
Convert TestAudioEventTimeline.cpp to a gtest. r=padenot.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ce032e762e19