Closed
Bug 1314556
Opened 4 years ago
Closed 4 years ago
Convert TestAudioEventTimeline.cpp to a gtest
Categories
(Core :: Web Audio, defect, P2)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
21.10 KB,
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
This removes another GeckoCppUnitTest, which helps with bug 1313141.
![]() |
Assignee | |
Comment 1•4 years ago
|
||
Attachment #8806651 -
Flags: review?(padenot)
Updated•4 years ago
|
Rank: 25
Priority: -- → P2
Comment 2•4 years ago
|
||
Comment on attachment 8806651 [details] [diff] [review] Convert TestAudioEventTimeline.cpp to a gtest Review of attachment 8806651 [details] [diff] [review]: ----------------------------------------------------------------- r+ with the comments addressed. Thanks for doing that Nicholas. Should we transition our other compiled tests to gTests, are they not causing issues? ::: dom/media/webaudio/gtest/TestAudioEventTimeline.cpp @@ +48,5 @@ > template <class T, class U> > void is(const T& a, const U& b, const char* msg) > { > std::stringstream ss; > + ss << msg << ", Got: " << a << ", expected: " << b << '\n'; `std::endl` instead of `\n` please. @@ +59,5 @@ > // stupidly high, since we mostly care about the correctness of the algorithm > const float kEpsilon = 0.00001f; > > std::stringstream ss; > + ss << msg << ", Got: " << a << ", expected: " << b << 'n'; `std::endl` instead of just the letter 'n' please :-).
Attachment #8806651 -
Flags: review?(padenot) → review+
![]() |
Assignee | |
Comment 3•4 years ago
|
||
> Should we transition our other compiled tests to gTests, are they not causing issues? I'm not sure exactly which tests you are referring to, but the ones in dom/media/compiledtest/ will need conversion too. I'll look at them soon. And see attachment 8806764 [details] for the full list of tests blocking bug 1313141.
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/ce032e762e19 Convert TestAudioEventTimeline.cpp to a gtest. r=padenot.
Comment 5•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ce032e762e19
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•