Silence warning from nsEffectiveTLDService::GetBaseDomain() when this gets called from DocGroup::GetKey() with null argument

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: Jorg K (GMT+2), Assigned: Jorg K (GMT+2))

Tracking

unspecified
mozilla52
Points:
---

Firefox Tracking Flags

(firefox52 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

962 bytes, patch
Jorg K (GMT+2)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

9 months ago
+++ This bug was initially created as a clone of Bug #1303196 +++

Silence warning from nsEffectiveTLDService::GetBaseDomain() when this gets called from DocGroup::GetKey() with null argument.

This was introduced in bug 1303196 here:
https://hg.mozilla.org/mozilla-central/rev/fe339dd59a01#l1.26
(Assignee)

Comment 1

9 months ago
Created attachment 8806667 [details] [diff] [review]
1314568.patch

See
https://dxr.mozilla.org/comm-central/rev/2c773b97167252cedcba0be0c7af9d4cab192ef5/mozilla/dom/base/nsWindowMemoryReporter.cpp#774
for similar treatment.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8806667 - Flags: review?(bugs)

Updated

9 months ago
Attachment #8806667 - Flags: review?(bugs) → review?(michael)
Comment on attachment 8806667 [details] [diff] [review]
1314568.patch

Review of attachment 8806667 [details] [diff] [review]:
-----------------------------------------------------------------

Good plan. I noticed this while I was developing the patch, but I suppose I never actually fixed it. Thank you very much!
Attachment #8806667 - Flags: review?(michael) → review+
(Assignee)

Comment 3

9 months ago
Created attachment 8806750 [details] [diff] [review]
1314568.patch

Thanks!
Carrying forward Michael's r+.
Changed the reviewer to "mystor" so it gets landed with the correct reviewer.
Attachment #8806667 - Attachment is obsolete: true
Attachment #8806750 - Flags: review+
(Assignee)

Updated

9 months ago
Keywords: checkin-needed

Comment 4

9 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5156607f031
Silence warning from nsEffectiveTLDService::GetBaseDomain(). r=mystor
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b5156607f031
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.