Closed Bug 1314568 Opened 7 years ago Closed 7 years ago

Silence warning from nsEffectiveTLDService::GetBaseDomain() when this gets called from DocGroup::GetKey() with null argument

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

Attachments

(1 file, 1 obsolete file)

1314568.patch
962 bytes, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1303196 +++

Silence warning from nsEffectiveTLDService::GetBaseDomain() when this gets called from DocGroup::GetKey() with null argument.

This was introduced in bug 1303196 here:
https://hg.mozilla.org/mozilla-central/rev/fe339dd59a01#l1.26
Attached patch 1314568.patch (obsolete) — — Splinter Review 
See
https://dxr.mozilla.org/comm-central/rev/2c773b97167252cedcba0be0c7af9d4cab192ef5/mozilla/dom/base/nsWindowMemoryReporter.cpp#774
for similar treatment.
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #8806667 - Flags: review?(bugs)
Attachment #8806667 - Flags: review?(bugs) → review?(michael)
Comment on attachment 8806667 [details] [diff] [review]
1314568.patch

Review of attachment 8806667 [details] [diff] [review]:
-----------------------------------------------------------------

Good plan. I noticed this while I was developing the patch, but I suppose I never actually fixed it. Thank you very much!
Attachment #8806667 - Flags: review?(michael) → review+
Attached patch 1314568.patch — — Splinter Review 
Thanks!
Carrying forward Michael's r+.
Changed the reviewer to "mystor" so it gets landed with the correct reviewer.
Attachment #8806667 - Attachment is obsolete: true
Attachment #8806750 - Flags: review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5156607f031
Silence warning from nsEffectiveTLDService::GetBaseDomain(). r=mystor
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b5156607f031
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.