1314729 - Some sites show 'Cannot Open Page' popup

Status: VERIFIED FIXED

(Firefox for iOS :: Browser, defect, P1)

Description

[No-Jun Park [:njpark]]

STR:
Open browser, type gizmodo.com in the url bar, press enter
Expected:
Browser displays site without error
Actual:
Browser displays the site, but it also shows a popup saying "Cannot Open Page - Firefox cannot open the page bacuse it has an invalid address."

Workaround:
Press OK each time it shows up.

This also happens on some other sites, not sure what's causing it.  Also happens during the scrolling of the page in some cases.

Version info:
git commit ebc73e30d36821fc15d24083d97f36d3f383b939
Device: iPhone 6s
OS: iOS 10.1.1

Comment 1

[Farhan Patel [:farhan]]

+1 I'm also getting this occasionally. I don't know why!

Comment 2

[Farhan Patel [:farhan]]

I can't seem to reproduce this anymore. Can you see if this still happens? 
I'm using a build with https://github.com/mozilla-mobile/firefox-ios/commit/2af5d3835b1a786d55e28774cb13988532a21c9f

This could be related to the mailto changes. Although looking at the code I don't see how this could be happening.

Comment 3

[Richard Newman [:rnewman]]

IIRC the last time this happened it was an ad iframe with a bad URL.

Comment 4

[Farhan Patel [:farhan]]

Yea that seems likely what was happening here. I guess the next question is do we really want to show an error here? In this case even though an ad might be broken the page loads fine. So an error here is really a nuisance. I'm gonna look into using WKNavigationType to see if the url is an explicit tap or something else. 

Does it make sense to _only_ show the error when someone clicks a bad link?

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Is it possible that you saw this on a build that did not have the fix from https://bugzilla.mozilla.org/show_bug.cgi?id=1312801 yet?

That patch fixed a very similar issue and it landed a few days before this was reported.

Before we make changes, I would really like to understand the exact URL that is causing this. Is there a site where this happens reliably?

Comment 6

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Is it possible that you saw this on a build that did not have the fix from https://bugzilla.mozilla.org/show_bug.cgi?id=1312801 yet?

That patch fixed a very similar issue and it landed a few days before this was reported.

Before we make changes, I would really like to understand the exact URL that is causing this. Is there a site where this happens reliably?

Comment 7

[No-Jun Park [:njpark]]

For me after rebuilding from the latest master, going to www.gizmodo.com shows the popup consistently.

Comment 8

[Farhan Patel [:farhan]]

This was fixed by https://bugzilla.mozilla.org/show_bug.cgi?id=1312801
I've confirmed with No-Jun that it is fixed with the patch from the above bug (he wasn't running a correct version of master earlier)

Comment 9

[Simon Basca [:SimonB]]

Tested on master 6dae35c6. 

According to previous comment I am verifying this as fix. This issue is not longer reproducible on gizmodo.com.