131480 - Can't do 2 successive history searches

Status: RESOLVED FIXED

(Core Graveyard :: History: Global, defect)

Description

[Bernard Alleysson]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+)
Gecko/20020301
BuildID:    2002031620



Reproducible: Always
Steps to Reproduce:
1.Ctrl +h
2.You have 1 window "History"
3.Ctrl +F
4 Search something and hit enter
5 You now have 2 windows, "History" + "Search Results"
6 Go back to "History" *without* closing "Search Results"
7 Ctrl +F
8 Search something else


Actual Results:  10 Nothing happens, there is no user feedback, nothing


Expected Results:  A second search Results window should be opened or the one
and only
"Search results" windows should be reused *and* bring to the top

I was stuck and I hit enter several times til
I realized I had to manually close the first "Search results"
window *before* submitting a second search

This is very poor UE

Comment 1

[Rene Pronk]

I noticed that performing the second find results in a javascript error in the
JavaScript Console:

Error: hstWindow.setRoot is not a function
Source File: chrome:// communicator/content/history/findHistory.js

Comment 2

[Arno Roefs]

User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0.0) Gecko/20020530
Build: 2002053012

Can't find a dupe.

Comment 3

[Blake Ross]

Well, this is an obvious 3-line fix if we want to fix this for machv.  I
accidentally removed this function back around February, I just need to add it
back to fix this.  But it's not very important.

Comment 4

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 5

[Mike Young]

blake, can you post the 3 line patch you mentioned earlier in this bug? Machv is
long gone, but this bug still seems to exist, and if it is trivial to fix, we
should try to do it.

Comment 6

[Andrei Leo]

*** Bug 148796 has been marked as a duplicate of this bug. ***

Comment 7

[parish]

If this ever gets fixed then can the position and/or size of the reulting Find
window be changed? At the moment it is exactly the same size and position as the
History window thus obscuring it. Since we are going to allow a second search we
need to be able to get back to the History window easily rather than having to
go a-hunting for it. I suggest that it opens down, and to the right of the
history window by the height of the title bar as Cascade does in Windows.

Comment 8

[Alfonso Martinez]

*** Bug 162641 has been marked as a duplicate of this bug. ***

Comment 9

[Alfonso Martinez]

*** Bug 148795 has been marked as a duplicate of this bug. ***

Comment 10

[Alfonso Martinez]

*** Bug 206980 has been marked as a duplicate of this bug. ***

Comment 11

[Alfonso Martinez]

Changing OS-> All based on dup 206980, although bug 1692641 comment #2 says that
it's WFM in FizzillaMach

Comment 12

[Stefan Borggraefe]

The lost function is in the patch attached to bug 96753. I'll try if adding it
back will fix this bug.

Comment 13

[Stefan Borggraefe]

Attachment: Patch

Well, it works with a slightly updated version of the lost function (I had to
change the id from historyOutliner to historyTree).

Comment 14

[[e-mail]]

Comment on attachment 152387 [details] [diff] [review]
Patch

I think that the existing search results will already have the correct title.
Also, I think you can use the ref property as an alternative to the attribute.
Finally r+sr doesn't apply to xpfe, find someone else to review (or sr).

Comment 15

[Stefan Borggraefe]

Attachment: Better patch

Addressed Neil's comments.

Comment 16

[[e-mail]]

Comment on attachment 155951 [details] [diff] [review]
Better patch

jag says I can now give r+sr on really simple patches :-)

Comment 17

[Stefan Borggraefe]

Comment on attachment 155951 [details] [diff] [review]
Better patch

I think this simple and low-risk patch would be nice to have in the 1.7-branch,
too.

Comment 18

[Mike Kaply [:mkaply]]

Comment on attachment 155951 [details] [diff] [review]
Better patch

a=mkaply for 1.7.3

Comment 19

[Stefan Borggraefe]

Fixed on trunk.

Comment 20

[Stefan Borggraefe]

*** Bug 274580 has been marked as a duplicate of this bug. ***