1314886 - Intermittent dom/media/test/test_streams_element_capture_reset.html | checking vout has not ended - got true, expected false

Status: RESOLVED FIXED

(Core :: Audio/Video: MediaStreamGraph, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=6078838&repo=autoland

https://queue.taskcluster.net/v1/task/B6IklHKzTCSC4p6gbqjaGg/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Intermittent Failures Robot]

11 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-inbound: 5
* autoland: 5
* mozilla-central: 1

Platform breakdown:
* linux32: 6
* linux64: 3
* osx-10-10: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314886&startday=2016-10-31&endday=2016-11-06&tree=all

Comment 2

[Intermittent Failures Robot]

35 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 16
* mozilla-inbound: 15
* mozilla-central: 3
* try: 1

Platform breakdown:
* linux64: 16
* osx-10-10: 9
* linux32: 9
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314886&startday=2016-11-07&endday=2016-11-13&tree=all

Comment 3

[Intermittent Failures Robot]

39 failures in 715 pushes (0.055 failures/push) were associated with this bug in the last 7 days.  

Repository breakdown:
* autoland: 20
* mozilla-inbound: 11
* mozilla-aurora: 3
* graphics: 3
* try: 1
* mozilla-central: 1

Platform breakdown:
* linux64: 23
* linux32: 12
* osx-10-10: 3
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314886&startday=2016-11-14&endday=2016-11-20&tree=all

Comment 4

[Intermittent Failures Robot]

16 failures in 141 pushes (0.113 failures/push) were associated with this bug yesterday.  

Repository breakdown:
* mozilla-inbound: 9
* autoland: 4
* try: 3

Platform breakdown:
* linux32: 8
* linux64: 7
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314886&startday=2016-11-22&endday=2016-11-22&tree=all

Comment 5

[Intermittent Failures Robot]

54 failures in 623 pushes (0.087 failures/push) were associated with this bug in the last 7 days. 

This is the #24 most frequent failure this week. 

** This failure happened more than 50 times this week! Resolving this bug is a high priority. **

Repository breakdown:
* autoland: 25
* mozilla-inbound: 23
* try: 3
* mozilla-aurora: 2
* mozilla-central: 1

Platform breakdown:
* linux32: 27
* linux64: 23
* osx-10-10: 2
* windows8-64: 1
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314886&startday=2016-11-21&endday=2016-11-27&tree=all

Comment 6

[Andreas Pehrson [:pehrsons]]

Raising prio here given the frequency. It might just be fallout from MediaStream.active, that changed how media elements end when playing MediaStreams.

Comment 7

[Intermittent Failures Robot]

28 failures in 694 pushes (0.04 failures/push) were associated with this bug in the last 7 days. 

This is the #46 most frequent failure this week. 

Repository breakdown:
* autoland: 14
* mozilla-inbound: 11
* mozilla-central: 2
* try: 1

Platform breakdown:
* linux64: 18
* linux32: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1314886&startday=2016-11-28&endday=2016-12-04&tree=all

Comment 8

[Andreas Pehrson [:pehrsons]]

Looking at Orangefactor it's clearly fallout from bug 1208316, but I'm not sure how yet.

Comment 9

[Andreas Pehrson [:pehrsons]]

I think this happens if the srcObject doesn't see any tracks asynchronously before v ends. We call mozCaptureStream before metadata has loaded so we rely on tracks appearing from MediaStreamGraph. That is an async operation and with the src of v being so short there might be timing issues.

Really I think the underlying problem is that HTMLMediaElement.ended is somewhat naively implemented as !MediaStream.active. This would mean that the media element is ended directly after play() if there were no tracks in the source.

Comment 10

[Andreas Pehrson [:pehrsons]]

Attachment: Bug 1314886 - Call mozCaptureStream() after "loadedmetadata" in test_streams_element_capture_reset.

The spec is very clear on this, so we should reflect it in code.

Review commit: https://reviewboard.mozilla.org/r/99268/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/99268/

Comment 11

[Randell Jesup [:jesup] (needinfo me)]

Issues in the Try

Comment 12

[Andreas Pehrson [:pehrsons]]

Actually there's language in mediacapture-main about ending on inactive that doesn't care for readyState.
It's in conflict with the html spec but the html spec has not been updated for MediaStreams yet. I'll stick with mediacapture-main then, and update this intermittent test to just have better guarantees on when the tracks are created.

Comment 13

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8819525 [details]
Bug 1314886 - Call mozCaptureStream() after "loadedmetadata" in test_streams_element_capture_reset.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99268/diff/1-2/

Comment 14

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8819525 [details]
Bug 1314886 - Call mozCaptureStream() after "loadedmetadata" in test_streams_element_capture_reset.

https://reviewboard.mozilla.org/r/99268/#review102130

::: dom/media/test/test_streams_element_capture_reset.html:124
(Diff revision 2)
> -  vout_untilended.play();
> +    vout_untilended.play();
> +
> +    v.play();
> +  };
> +
> +  v.addEventListener("loadedmetadata", loadedmetadata, false);

You can do:
v.addEventListener('someEvent', handler_once, {once: true});

Comment 15

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8819525 [details]
Bug 1314886 - Call mozCaptureStream() after "loadedmetadata" in test_streams_element_capture_reset.

https://reviewboard.mozilla.org/r/99268/#review102130

> You can do:
> v.addEventListener('someEvent', handler_once, {once: true});

Such modern! Thanks.

Comment 16

[Andreas Pehrson [:pehrsons]]

Comment on attachment 8819525 [details]
Bug 1314886 - Call mozCaptureStream() after "loadedmetadata" in test_streams_element_capture_reset.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/99268/diff/2-3/

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bafb20dd3221
Call mozCaptureStream() after "loadedmetadata" in test_streams_element_capture_reset. r=jwwang

Comment 18

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/bafb20dd3221

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/998a1b4c7613