Closed
Bug 1314891
Opened 8 years ago
Closed 8 years ago
create_window_instance() should not fail with UnknownWindowError but create a BaseWindow
Categories
(Testing :: Firefox UI Tests, defect)
Tracking
(firefox-esr45 fixed, firefox50 fixed, firefox51 fixed, firefox52 fixed)
RESOLVED
FIXED
mozilla52
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
Attachments
(1 file)
As seen on bug 1256425 we currently fail to handle unknown window types correctly. The behavior at the moment is that we raise an UnknownWindowError exception. I don't think that this is a good way to continue because it limits us to always have to define window types in Puppeteer. Like in the above case it can cause unexpected failures and maybe hangs of Marionette. So in cases when we do not know about the window type lets create a BaseWindow.
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8807078 -
Flags: review?(mjzffr)
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8807078 [details] Bug 1314891 - create_window_instance() should not fail with UnknownWindowError but create a BaseWindow. https://reviewboard.mozilla.org/r/90362/#review90100
Attachment #8807078 -
Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c2d2dfc302e create_window_instance() should not fail with UnknownWindowError but create a BaseWindow. r=maja_zf
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0c2d2dfc302e
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
|
|
Assignee | |
Comment 5•8 years ago
|
||
I'm asking for landing this patch even on beta or currently release given that this was a real blocker for QA when running the update tests. I know it's late but maybe it can still be done?
|
||
Comment 6•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-aurora/rev/278308ec64f5
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
|
|
||
Comment 7•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-release/rev/87f8b968e129
|
|
Assignee | |
Updated•8 years ago
|
Whiteboard: [checkin-needed-esr45]
|
|
||
Comment 8•8 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-esr45/rev/6d686cc08c48
Whiteboard: [checkin-needed-esr45]
You need to log in
before you can comment on or make changes to this bug.
Description
•