Closed Bug 1314891 Opened 3 years ago Closed 3 years ago
_window _instance() should not fail with Unknown Window Error but create a Base Window
Bug 1314891 - create_window_instance() should not fail with UnknownWindowError but create a BaseWindow.
58 bytes, text/x-review-board-request
As seen on bug 1256425 we currently fail to handle unknown window types correctly. The behavior at the moment is that we raise an UnknownWindowError exception. I don't think that this is a good way to continue because it limits us to always have to define window types in Puppeteer. Like in the above case it can cause unexpected failures and maybe hangs of Marionette. So in cases when we do not know about the window type lets create a BaseWindow.
Attachment #8807078 - Flags: review?(mjzffr)
Comment on attachment 8807078 [details] Bug 1314891 - create_window_instance() should not fail with UnknownWindowError but create a BaseWindow. https://reviewboard.mozilla.org/r/90362/#review90100
Attachment #8807078 - Flags: review?(mjzffr) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/0c2d2dfc302e create_window_instance() should not fail with UnknownWindowError but create a BaseWindow. r=maja_zf
I'm asking for landing this patch even on beta or currently release given that this was a real blocker for QA when running the update tests. I know it's late but maybe it can still be done?
You need to log in before you can comment on or make changes to this bug.