create_window_instance() should not fail with UnknownWindowError but create a BaseWindow

RESOLVED FIXED in Firefox -esr45

Status

Testing
Firefox UI Tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

50 Branch
mozilla52
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox-esr45 fixed, firefox50 fixed, firefox51 fixed, firefox52 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
As seen on bug 1256425 we currently fail to handle unknown window types correctly. The behavior at the moment is that we raise an UnknownWindowError exception. 

I don't think that this is a good way to continue because it limits us to always have to define window types in Puppeteer. Like in the above case it can cause unexpected failures and maybe hangs of Marionette.

So in cases when we do not know about the window type lets create a BaseWindow.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8807078 - Flags: review?(mjzffr)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8807078 [details]
Bug 1314891 - create_window_instance() should not fail with UnknownWindowError but create a BaseWindow.

https://reviewboard.mozilla.org/r/90362/#review90100
Attachment #8807078 - Flags: review?(mjzffr) → review+

Comment 3

2 years ago
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c2d2dfc302e
create_window_instance() should not fail with UnknownWindowError but create a BaseWindow. r=maja_zf

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0c2d2dfc302e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
(Assignee)

Updated

2 years ago
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
(Assignee)

Comment 5

2 years ago
I'm asking for landing this patch even on beta or currently release given that this was a real blocker for QA when running the update tests. I know it's late but maybe it can still be done?

Comment 6

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/278308ec64f5
status-firefox51: affected → fixed
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-release/rev/87f8b968e129
status-firefox50: affected → fixed
Flags: in-testsuite+
Whiteboard: [checkin-needed-beta]
(Assignee)

Updated

2 years ago
Whiteboard: [checkin-needed-esr45]

Comment 8

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-esr45/rev/6d686cc08c48
status-firefox-esr45: affected → fixed
Whiteboard: [checkin-needed-esr45]
You need to log in before you can comment on or make changes to this bug.