Closed Bug 1314891 Opened 4 years ago Closed 4 years ago

create_window_instance() should not fail with UnknownWindowError but create a BaseWindow

Categories

(Testing :: Firefox UI Tests, defect)

Product:
Testing
Component:
Firefox UI Tests
Version:
50 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr45 fixed, firefox50 fixed, firefox51 fixed, firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox-esr45 --- fixed
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

Attachments

(1 file)

Bug 1314891 - create_window_instance() should not fail with UnknownWindowError but create a BaseWindow.
58 bytes, text/x-review-board-request
impossibus
: review+
Details 
As seen on bug 1256425 we currently fail to handle unknown window types correctly. The behavior at the moment is that we raise an UnknownWindowError exception. 

I don't think that this is a good way to continue because it limits us to always have to define window types in Puppeteer. Like in the above case it can cause unexpected failures and maybe hangs of Marionette.

So in cases when we do not know about the window type lets create a BaseWindow.
Attachment #8807078 - Flags: review?(mjzffr)
Comment on attachment 8807078 [details]
Bug 1314891 - create_window_instance() should not fail with UnknownWindowError but create a BaseWindow.

https://reviewboard.mozilla.org/r/90362/#review90100
Attachment #8807078 - Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0c2d2dfc302e
create_window_instance() should not fail with UnknownWindowError but create a BaseWindow. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/0c2d2dfc302e
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Whiteboard: [checkin-needed-aurora][checkin-needed-beta]
I'm asking for landing this patch even on beta or currently release given that this was a real blocker for QA when running the update tests. I know it's late but maybe it can still be done?
https://hg.mozilla.org/releases/mozilla-aurora/rev/278308ec64f5
status-firefox51: affected → fixed
Whiteboard: [checkin-needed-aurora][checkin-needed-beta] → [checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-release/rev/87f8b968e129
status-firefox50: affected → fixed
Flags: in-testsuite+
Whiteboard: [checkin-needed-beta]
Whiteboard: [checkin-needed-esr45]
You need to log in before you can comment on or make changes to this bug.