Closed Bug 1314903 Opened 8 years ago Closed 7 years ago

ParentAPIManager should not invoke error callback when data.childId is not set

Categories

(WebExtensions :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1316396

People

(Reporter: robwu, Assigned: robwu)

Details

Attachments

(1 file)

http://searchfox.org/mozilla-central/rev/f5c9e9a249637c9abd88754c8963ecb3838475cb/toolkit/components/extensions/Extension.jsm#531 should only be invoked if the callId is not unset.

Otherwise "TypeError: deferred is undefined" is triggered in the receiveMessage method of ChildAPIManager.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Comment on attachment 8838661 [details]
Bug 1314903 has been fixed, use callParentFunctionNoReturn in ext-c-omnibox.js

https://reviewboard.mozilla.org/r/113490/#review115042

thanks!
Attachment #8838661 - Flags: review?(mwein) → review+
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/0e1e91d22137
has been fixed, use callParentFunctionNoReturn in ext-c-omnibox.js r=mattw
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.