1315070 - Assertion failure: mConcurrentCacheAccess, at netwerk/protocol/http/nsHttpChannel.cpp:1230

Status: RESOLVED INVALID

(Core :: Networking: HTTP, defect)

Description

[Honza Bambas (:mayhemer)]

Assertion failure: mConcurrentCacheAccess, at c:/Mozilla/src/mozilla-central/netwerk/protocol/http/nsHttpChannel.cpp:1230
#01: mozilla::net::nsHttpChannel::OnAuthCancelled (c:\mozilla\src\mozilla-central\netwerk\protocol\http\nshttpchannel.cpp:5488)
#02: mozilla::net::nsHttpChannelAuthProvider::OnAuthCancelled (c:\mozilla\src\mozilla-central\netwerk\protocol\http\nshttpchannelauthprovider.cpp:1344)

Can happen when auth dialog is internally canceled (bug 1312243).  We are apparently trying to call onstartrequest more than once.  There is a condition to block it, but the multiple call so far was allowed only under one certain condition - concurrent cache read.

So, we may want to remove that assertion or look if it can be modified to let pass also this case.  Maybe mAuthRetryPending which is true at this moment added to the condition.

Comment 1

[Honza Bambas (:mayhemer)]

Note that this happened only when I had a mistake in the patch for bug 1312243.  That mistake internally canceled an auth dialog also for the top level document on reload.  This is not anything that should happen regularly with the final version of the patch for that bug.

Comment 2

[Honza Bambas (:mayhemer)]

Irreproducible, I don't think we need an immediate fix here.

Comment 3

[Honza Bambas (:mayhemer)]

Oh, this is actually my mistake introduced in login manager in bug 1312243.  No actual bug.