1315080 - unable to run dom/media mochitests locally due to missing python library

Status: RESOLVED WORKSFORME

(Core :: WebRTC: Networking, defect, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

elvis@JMAHER-WIN10 ~/mozilla-inbound
$ ./mach mochitest dom/media/tests/mochitest/test_getUserMedia_callbacks.html

######
### Now running mochitest-plain with subsuite media.
######

Checking for orphan ssltunnel processes...
Checking for orphan xpcshell processes...
SUITE-START | Running 1 tests
dir: dom/media/tests/mochitest/test_getUserMedia_callbacks.html
JMAHER: iteration: 1, repeat: 10, tests: [u'dom/media/tests/mochitest/test_getUserMedia_callbacks.html']
mozprofile.addons WARNING | Could not install c:\Users\elvis\mozilla-inbound\obj-i686-pc-mingw32\_tests\testing\mochitest\extensions\mozscreenshots: [Errno 2] No such file or directory: 'c:\\Users\\elvis\\mozilla-inbound\\obj-i686-pc-mingw32\\_tests\\testing\\mochitest\\extensions\\mozscreenshots\\install.rdf'
c:\Users\elvis\mozilla-inbound\obj-i686-pc-mingw32\dist\bin\pk12util.exe: PKCS12 IMPORT SUCCESSFUL
MochitestServer : launching [u'c:\\Users\\elvis\\mozilla-inbound\\obj-i686-pc-mingw32\\dist\\bin\\xpcshell.exe', '-g', u'c:\\Users\\elvis\\mozilla-inbound\\obj-i686-pc-mingw32\\dist\\bin', '-v', '170', '-f', u'c:\\Users\\elvis\\mozilla-inbound\\obj-i686-pc-mingw32\\dist\\bin\\components\\httpd.js', '-e', "const _PROFILE_PATH = 'c:\\\\users\\\\elvis\\\\appdata\\\\local\\\\temp\\\\tmp5f0m4d.mozrunner'; const _SERVER_PORT = '8888'; const _SERVER_ADDR = '127.0.0.1'; const _TEST_PREFIX = undefined; const _DISPLAY_RESULTS = false;", '-f', 'c:\\Users\\elvis\\mozilla-inbound\\obj-i686-pc-mingw32\\_tests\\testing\\mochitest\\server.js']
runtests.py | Server pid: 6108
runtests.py | Websocket server pid: 14612
runtests.py | websocket/process bridge pid: 11472
Traceback (most recent call last):
  File "websocketprocessbridge\websocketprocessbridge.py", line 6, in <module>
    from twisted.internet import protocol, reactor
ImportError: No module named twisted.internet


elvis@JMAHER-WIN10 ~/mozilla-inbound
$

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

I had also tried a:
* mach clobber
* mach build (artifact build)
* mach mochitest ...

still no luck.

Comment 2

[Andrew Halberstadt [:ahal]]

You need to do "pip install -r testing/tools/websocketprocessbridge/websocketprocessbridge_requirements.txt".

There's a patch in bug 1290765 that fixes this, but it can't land because we are still using a very old version of pip in CI. I'll see if I can get a version of that patch that works with older pip's landed.

Comment 3

[Byron Campen [:bwc]]

This shouldn't be preventing that test from running.

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

this does prevent tests from running- but :ahal's command allowed me to move forward and run tests locally.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

It could be it's only blocked on Windows if that module isn't installed.  If bug 1290765 is fixed, this bug may become moot (or less important)

Comment 6

[Andrew Halberstadt [:ahal]]

Byron, we start the websocketProcessBridge anytime any test that is part of the "media" subsuite gets run:
https://dxr.mozilla.org/mozilla-central/source/testing/mochitest/runtests.py#1130

So though that test may not use the server, we are starting it anyway. It may be worthwhile to look into a better way of detecting whether the server needs to be started or not (probably using a key in the test manifests).

Anyway, I put up a patch in bug 1290765. It fixes the ImportError for me, though the harness still hangs and times out when running:
./mach mochitest dom/media/tests/mochitest/test_getUserMedia_callbacks.html

I'm not sure what I'm doing wrong.. but if the patches there fix the issue for everyone here, feel free to RESOLVE DUPLICATE this.

Comment 7

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.

Comment 8

[Bob Clary [:bc] (inactive)]

jmaher: wfm on m-c from this morning. still an issue for you?

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

thanks for asking, this works great.