1315235 - Intermittent test_fallback_update.py TestFallbackUpdate.test_update | AttributeError: 'Preferences' object has no attribute 'restore_pref'

Status: RESOLVED FIXED

(Testing :: Firefox UI Tests, defect)

Description

[Treeherder Bug Filer]

Filed by: hskupin [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=5500687&repo=mozilla-central

https://firefox-ui-tests.s3.amazonaws.com/470b82b0-9fe4-4274-b019-dcf3531b875a/log_info.log

This is a regression from bug 1303863 which landed recently.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

It looks like the patch was not complete and we missed at minimum a single call to restore_pref():

05:44:28     INFO -     download_via_update_wizard(window)
05:44:28     INFO -   File "c:\jenkins\workspace\mozilla-central_update\build\venv\lib\site-packages\firefox_ui_harness\testcases.py", line 265, in download_via_update_wizard
05:44:28     INFO -     prefs.restore_pref(self.PREF_APP_UPDATE_ALTWINDOWTYPE)

I will get this patched.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1315235 - Remove remaining call to restore_pref() from update tests.

Review commit: https://reviewboard.mozilla.org/r/90676/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/90676/

Comment 3

[James Graham [:jgraham]]

Comment on attachment 8807529 [details]
Bug 1315235 - Remove remaining call to restore_pref() from update tests.

https://reviewboard.mozilla.org/r/90676/#review90356

Comment 4

[Johannes Vogel (:nebelhom)]

Why was this not triggered during our tests before landing the patch?

Did throw the testing net too small?

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Update tests cannot be run via try, and are also not getting run for checkins. This is a nightly and release build only test suite.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bd71ef29d81
Remove remaining call to restore_pref() from update tests. r=jgraham

Comment 7

[Intermittent Failures Robot]

40 automation job failures were associated with this bug yesterday.

Repository breakdown:
* mozilla-central: 40

Platform breakdown:
* windowsxp: 4
* windows8-64: 4
* windows8-32: 4
* windows7-64: 4
* windows7-32: 4
* osx-10-9: 4
* osx-10-11: 4
* osx-10-10: 4
* linux64: 4
* linux32: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1315235&startday=2016-11-04&endday=2016-11-04&tree=all

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/5bd71ef29d81

Comment 9

[Intermittent Failures Robot]

89 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 89

Platform breakdown:
* windows8-64: 13
* windows7-64: 13
* windowsxp: 9
* windows8-32: 9
* windows7-32: 9
* osx-10-9: 8
* osx-10-11: 8
* osx-10-10: 8
* linux64: 8
* linux32: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1315235&startday=2016-10-31&endday=2016-11-06&tree=all