1315244 - (SQLite3.15.1) Upgrade to SQLite 3.15.1

Status: RESOLVED FIXED

(Toolkit :: Storage, defect, P3)

Description

[Ryan VanderMeulen [:RyanVM]]

https://sqlite.org/news.html

SQLite version 3.15.1 is a bug-fix patch release that fixes some minor issues in the 3.15.0 release. 

http://sqlite.org/releaselog/3_15_1.html

* Added SQLITE_FCNTL_WIN32_GET_HANDLE file control opcode.

Bug Fixes:
* Fix the VACUUM command so that it spills excess content to disk rather than holding everything in memory, and possible causing an out-of-memory error for larger database files. This fixes an issue introduced by version 3.15.0.
* Fix a case (present since 3.8.0 - 2013-08-26) where OR-connected terms in the ON clause of a LEFT JOIN might cause incorrect results. Ticket 34a579141b2c5ac.
* Fix a case where the use of row values in the ON clause of a LEFT JOIN might cause incorrect results. Ticket fef4bb4bd9185ec8f.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Upgrade SQLite to version 3.15.1

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

The VACUUM issue sounds potentially significant for IndexedDB[1], so we very likely want this before the next merge date (2016-11-14?).

1: Places is also fancy and vacuums, but IndexedDB usage and databases going idle correlate with asm.js usage which can leave the address space exhaused and/or very fragmented on 32-bit systems.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8807531 [details] [diff] [review]
Upgrade SQLite to version 3.15.1

Review of attachment 8807531 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/41d172f46ee9
Upgrade to SQLite 3.15.1. r=mak

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/41d172f46ee9

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8eed0b176b5
Upgrade to SQLite 3.15.2. r=mak

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Gah.